Skip to content

Commit cb0c9d2

Browse files
authored
Deploy with auto build (#17)
* Remove `npm run build` step, since the Node buildpack now runs it automatically, https://devcenter.heroku.com/changelog-items/1557 * 📚 clarify how this project fits into React deployment
1 parent 26c4b85 commit cb0c9d2

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Inner layer of Heroku Buildpack for create-react-app
22
====================================================
33

4-
See: [create-react-app-buildpack](https://github.com/mars/create-react-app-buildpack)
4+
See: [create-react-app-buildpack's architecture](https://github.com/mars/create-react-app-buildpack/blob/master/README.md#user-content-architecture-) for how this helps deploy React apps.
55

66
[![Build Status](https://travis-ci.org/mars/create-react-app-inner-buildpack.svg?branch=master)](https://travis-ci.org/mars/create-react-app-inner-buildpack)
77

bin/compile

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -55,17 +55,3 @@ cp "$BP_DIR/lib/injectable_env.rb" "$cra_dir/"
5555
profile_d_dir="$BUILD_DIR/.profile.d"
5656
mkdir -p "$profile_d_dir"
5757
cp "$BP_DIR/.profile.d/inject_react_app_env.sh" "$profile_d_dir/"
58-
59-
# Support env vars during build:
60-
# * `REACT_APP_*`
61-
# * https://github.com/facebookincubator/create-react-app/blob/v0.2.3/template/README.md#adding-custom-environment-variables
62-
# * `NODE_*`, especially for `NODE_PATH`
63-
# * https://github.com/facebookincubator/create-react-app/pull/476
64-
# * `NPM_*`, especially for `NPM_TOKEN`
65-
# * https://docs.npmjs.com/private-modules/ci-server-config
66-
# * `HEROKU_*`, especially for Dyno Metadata
67-
# * https://devcenter.heroku.com/articles/dyno-metadata
68-
export_env_dir "$ENV_DIR" '^(REACT_APP_|NODE_|NPM_|HEROKU_)'
69-
70-
# Build the javascript bundle
71-
npm run build

0 commit comments

Comments
 (0)