feat: Add hard_link_or_copy function to MartianRover #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklin-10x
reviewed
Oct 30, 2023
macklin-10x
approved these changes
Oct 30, 2023
| /// | ||
| /// * The path of the newly created link | ||
| pub fn hard_link_or_copy<M: MartianFileType>(&self, src: &M) -> Result<M, Error> { | ||
| let stem = src.as_ref().file_name().expect("Could not get file name."); |
There was a problem hiding this comment.
To aid in debugging, please include the full path contents in the expect message.
| pub fn hard_link_or_copy<M: MartianFileType>(&self, src: &M) -> Result<M, Error> { | ||
| let stem = src.as_ref().file_name().expect("Could not get file name."); | ||
| let dst: M = self.make_path(stem); | ||
| std::fs::hard_link(src, &dst).or_else(|_| std::fs::copy(src, &dst).map(|_| ()))?; |
There was a problem hiding this comment.
Same thing here; we should include the input path as context in any error message emanating from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.