Use default file explorer when possible (fix #4063)

Author: marticliment

src/UniGetUI.Core.Tools/Tools.cs

@@ -5,6 +5,7 @@
 using System.Security.Principal;
 using System.Text;
 using Windows.Networking.Connectivity;
+using ABI.Windows.ApplicationModel.UserDataTasks;
 using UniGetUI.Core.Classes;
 using UniGetUI.Core.Data;
 using UniGetUI.Core.Language;
@@ -720,13 +721,36 @@ public static async Task ShowFileOnExplorer(string path)
             }
         }
 
+        public static void Launch(string? path)
+        {
+            try
+            {
+                if (path is null) return;
+
+                var p = new Process()
+                {
+                    StartInfo = new()
+                    {
+                        FileName = path,
+                        UseShellExecute = true,
+                        CreateNoWindow = true,
+                    }
+                };
+                p.Start();
+            }
+            catch (Exception ex)
+            {
+                Logger.Error(ex);
+            }
+        }
+
         public static string GetCurrentLocale()
         {
             return LanguageEngine?.Locale ?? "Unset/Unknown";
         }
 
-        private static readonly HashSet<char> illegalPathChars = Path.GetInvalidFileNameChars().ToHashSet();
+        private static readonly HashSet<char> _illegalPathChars = Path.GetInvalidFileNameChars().ToHashSet();
         public static string MakeValidFileName(string name)
-            => string.Concat(name.Where(x => !illegalPathChars.Contains(x)));
+            => string.Concat(name.Where(x => !_illegalPathChars.Contains(x)));
     }
 }

src/UniGetUI/CLIHandler.cs

@@ -1,6 +1,7 @@
 using UniGetUI.Core.Logging;
 using UniGetUI.Core.SettingsEngine;
 using UniGetUI.Core.SettingsEngine.SecureSettings;
+using UniGetUI.Core.Tools;
 
 namespace UniGetUI;
 
@@ -37,11 +38,8 @@ private enum HRESULT
 
     public static int Help()
     {
-        System.Diagnostics.Process.Start(new System.Diagnostics.ProcessStartInfo
-        {
-            FileName = "https://github.com/marticliment/UniGetUI/blob/main/cli-arguments.md#unigetui-command-line-parameters",
-            UseShellExecute = true
-        });
+        var url = "https://github.com/marticliment/UniGetUI/blob/main/cli-arguments.md#unigetui-command-line-parameters";
+        CoreTools.Launch(url);
         return 0;
     }
 

src/UniGetUI/Controls/OperationWidgets/OperationControl.cs

@@ -629,14 +629,7 @@ public List<MenuFlyoutItemBase> GetOperationOptions()
                 Text = CoreTools.Translate("Open install location"),
                 IconName = IconType.OpenFolder,
             };
-            openLocation.Click += (_, _) =>
-            {
-                Process.Start(new ProcessStartInfo {
-                    FileName = location ?? "",
-                    UseShellExecute = true,
-                    Verb = "open"
-                });
-            };
+            openLocation.Click += (_, _) => CoreTools.Launch(location);
             openLocation.IsEnabled = location is not null && Directory.Exists(location);
             optionsMenu.Add(openLocation);
         }
@@ -647,22 +640,7 @@ public List<MenuFlyoutItemBase> GetOperationOptions()
                 Text = CoreTools.Translate("Open"),
                 IconName = IconType.Launch,
             };
-            launchInstaller.Click += (_, _) =>
-            {
-                try
-                {
-                    Process.Start(new ProcessStartInfo
-                    {
-                        FileName = downloadOp.DownloadLocation,
-                        UseShellExecute = true
-                    });
-                }
-                catch (Exception ex)
-                {
-                    Logger.Error($"An error occurred while attempting to launch the file {downloadOp.DownloadLocation}.");
-                    Logger.Error(ex);
-                }
-            };
+            launchInstaller.Click += (_, _) => CoreTools.Launch(downloadOp.DownloadLocation);
             launchInstaller.IsEnabled = downloadOp.Status is OperationStatus.Succeeded;
             optionsMenu.Add(launchInstaller);
 

src/UniGetUI/Pages/HelpPage.xaml.cs

@@ -1,6 +1,7 @@
 using System.Diagnostics;
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
+using UniGetUI.Core.Tools;
 using UniGetUI.Interface.Pages;
 
 // To learn more about WinUI, the WinUI project structure,
@@ -83,27 +84,27 @@ private void RightButton_Click(object sender, RoutedEventArgs e)
 
         private void HomeButton_Click(object sender, RoutedEventArgs e)
         {
+            if (!Initialized || webView is null)
+                return;
 
-            if (Initialized && webView is not null)
-            {
-                webView.Source = new Uri("https://marticliment.com/unigetui/help");
-            }
+            webView.Source = new Uri("https://marticliment.com/unigetui/help");
         }
 
         private void ReloadButton_Click(object sender, RoutedEventArgs e)
         {
-            if (Initialized && webView is not null)
-            {
-                webView.Reload();
-            }
+            if (!Initialized || webView is null)
+                return;
+
+            webView.Reload();
         }
 
         private void BrowserButton_Click(object sender, RoutedEventArgs e)
         {
-            if (Initialized && webView is not null)
-            {
-                Process.Start(new ProcessStartInfo { FileName = webView.Source.ToString().Replace("?isWingetUIIframe", "").Replace("&isWingetUIIframe", ""), UseShellExecute = true });
-            }
+            if (!Initialized || webView is null)
+                return;
+
+            string uri = webView.Source.ToString().Replace("?isWingetUIIframe", "").Replace("&isWingetUIIframe", "");
+            CoreTools.Launch(uri);
         }
 
         public void Dispose()

src/UniGetUI/Pages/SettingsPages/GeneralPages/Backup.xaml.cs

@@ -100,19 +100,12 @@ private void ResetBackupPath_Click(object sender, RoutedEventArgs e)
         private void OpenBackupPath_Click(object sender, RoutedEventArgs e)
         {
             string directory = Settings.GetValue(Settings.K.ChangeBackupOutputDirectory);
-            if (directory == "")
-            {
-                directory = CoreData.UniGetUI_DefaultBackupDirectory;
-            }
+            if (directory == "") directory = CoreData.UniGetUI_DefaultBackupDirectory;
 
             directory = directory.Replace("/", "\\");
+            if (!Directory.Exists(directory)) Directory.CreateDirectory(directory);
 
-            if (!Directory.Exists(directory))
-            {
-                Directory.CreateDirectory(directory);
-            }
-
-            Process.Start("explorer.exe", directory);
+            CoreTools.Launch(directory);
         }
 
         private void DoBackup_LOCAL_Click(object sender, EventArgs e) => _ = _doBackup_LOCAL_Click();

src/UniGetUI/Pages/SettingsPages/GeneralPages/Interface_P.xaml.cs

@@ -91,17 +91,6 @@ private void ThemeSelector_ValueChanged(object sender, EventArgs e)
             => MainApp.Instance.MainWindow.ApplyTheme();
 
         private void EditAutostartSettings_Click(object sender, EventArgs e)
-        {
-            using Process p = new()
-            {
-                StartInfo = new ProcessStartInfo
-                {
-                    FileName = "ms-settings:startupapps",
-                    UseShellExecute = true,
-                    CreateNoWindow = true
-                }
-            };
-            p.Start();
-        }
+            => CoreTools.Launch("ms-settings:startupapps");
     }
 }

src/UniGetUI/Pages/SettingsPages/ManagersPages/PackageManager.xaml.cs

@@ -314,7 +314,7 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
                 OpenVcPkgRootLabel.Click += (_, _) =>
                 {
                     string directory = Settings.GetValue(Settings.K.CustomVcpkgRoot).Replace("/", "\\");
-                    if (directory.Any()) Process.Start("explorer.exe", directory);
+                    if (directory.Any()) CoreTools.Launch(directory);
                 };
 
                 Vcpkg_CustomVcpkgRoot.Click += (_, _) =>

src/UniGetUI/Pages/SoftwarePages/AbstractPackagesPage.xaml.cs

@@ -1014,14 +1014,7 @@ protected void ShowDetailsForPackage(IPackage? package, TEL_InstallReferral refe
         protected void OpenPackageInstallLocation(IPackage? package)
         {
             string? path = package?.Manager.DetailsHelper.GetInstallLocation(package);
-
-            if (path is not null)
-                Process.Start(new ProcessStartInfo
-                {
-                    FileName = path,
-                    UseShellExecute = true,
-                    Verb = "open"
-                });
+            CoreTools.Launch(path);
         }
 
         protected void SharePackage(IPackage? package)