Skip to content

Commit 183e122

Browse files
committed
[TESTING/WIP] ci/coverage: Test proxy-wasm-cpp-sdk PR#157
proxy-wasm/proxy-wasm-cpp-sdk#157 Signed-off-by: Martijn Stevenson <[email protected]>
1 parent 8d48ccd commit 183e122

File tree

3 files changed

+18
-21
lines changed

3 files changed

+18
-21
lines changed

bazel/dependency_imports.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def envoy_dependency_imports(go_version = GO_VERSION, jq_version = JQ_VERSION, y
5757
oss_fuzz = True,
5858
honggfuzz = False,
5959
)
60-
emscripten_deps(emscripten_version = "3.1.7")
60+
emscripten_deps(emscripten_version = "3.1.44")
6161
register_jq_toolchains(version = jq_version)
6262
register_yq_toolchains(version = yq_version)
6363
parser_deps()

bazel/emsdk.patch

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
diff --git a/bazel/emscripten_deps.bzl b/bazel/emscripten_deps.bzl
2-
index 95801ba..95fdabd 100644
2+
index 219cd93..c127d49 100644
33
--- a/bazel/emscripten_deps.bzl
44
+++ b/bazel/emscripten_deps.bzl
5-
@@ -69,31 +69,3 @@ def emscripten_deps(emscripten_version = "latest"):
6-
build_file = "@emsdk//emscripten_toolchain:emscripten.BUILD",
5+
@@ -167,38 +167,3 @@ def emscripten_deps(emscripten_version = "latest"):
6+
build_file_content = BUILD_FILE_CONTENT_TEMPLATE.format(bin_extension = ".exe"),
77
type = "zip",
88
)
99
-
@@ -14,6 +14,13 @@ index 95801ba..95fdabd 100644
1414
- package_lock_json = "@emscripten_bin_linux//:emscripten/package-lock.json",
1515
- )
1616
-
17+
- if "emscripten_npm_linux_arm64" not in excludes:
18+
- npm_install(
19+
- name = "emscripten_npm_linux_arm64",
20+
- package_json = "@emscripten_bin_linux_arm64//:emscripten/package.json",
21+
- package_lock_json = "@emscripten_bin_linux_arm64//:emscripten/package-lock.json",
22+
- )
23+
-
1724
- if "emscripten_npm_mac" not in excludes:
1825
- npm_install(
1926
- name = "emscripten_npm_mac",
@@ -34,15 +41,3 @@ index 95801ba..95fdabd 100644
3441
- package_json = "@emscripten_bin_win//:emscripten/package.json",
3542
- package_lock_json = "@emscripten_bin_win//:emscripten/package-lock.json",
3643
- )
37-
diff --git a/bazel/emscripten_toolchain/BUILD.bazel b/bazel/emscripten_toolchain/BUILD.bazel
38-
index eb36959..12dba37 100644
39-
--- a/bazel/emscripten_toolchain/BUILD.bazel
40-
+++ b/bazel/emscripten_toolchain/BUILD.bazel
41-
@@ -13,7 +13,6 @@ filegroup(
42-
"env.sh",
43-
"env.bat",
44-
"@emsdk//:binaries",
45-
- "@emsdk//:node_modules",
46-
"@nodejs//:node_files",
47-
],
48-
)

bazel/repository_locations.bzl

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1300,12 +1300,13 @@ REPOSITORY_LOCATIONS_SPEC = dict(
13001300
license = "Apache-2.0",
13011301
license_url = "https://github.com/dpkp/kafka-python/blob/{version}/LICENSE",
13021302
),
1303+
# TEST: https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/pull/157/
13031304
proxy_wasm_cpp_sdk = dict(
13041305
project_name = "WebAssembly for Proxies (C++ SDK)",
13051306
project_desc = "WebAssembly for Proxies (C++ SDK)",
13061307
project_url = "https://github.com/proxy-wasm/proxy-wasm-cpp-sdk",
1307-
version = "e30535b7c0cd3126e6401bc3769063a74bbb37be",
1308-
sha256 = "94e474ebea782225821224734ed5992fa749301e12e06b6520b8b4d4e1c05ffc",
1308+
version = "6efffe99a90d764b063b9fa8213d2c34ae69a7da",
1309+
sha256 = "db00ef59d8024d0db74a269ece76d8106c1e9afc1abed237aea8366a8db2983e",
13091310
strip_prefix = "proxy-wasm-cpp-sdk-{version}",
13101311
urls = ["https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/archive/{version}.tar.gz"],
13111312
use_category = ["dataplane_ext"],
@@ -1366,13 +1367,14 @@ REPOSITORY_LOCATIONS_SPEC = dict(
13661367
license = "Apache-2.0",
13671368
license_url = "https://github.com/proxy-wasm/proxy-wasm-rust-sdk/blob/v{version}/LICENSE",
13681369
),
1370+
# TEST: https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/pull/157/
13691371
emsdk = dict(
13701372
project_name = "Emscripten SDK",
13711373
project_desc = "Emscripten SDK (use by Wasm)",
13721374
project_url = "https://github.com/emscripten-core/emsdk",
1373-
# v3.1.7 with Bazel fixes
1374-
version = "0ea8f8a8707070e9a7c83fbb4a3065683bcf1799",
1375-
sha256 = "1ca0ff918d476c55707bb99bc0452be28ac5fb8f22a9260a8aae8a38d1bc0e27",
1375+
# v3.1.44 with one Bazel platforms fix
1376+
version = "ef2a8e929d5337755e9b1d1e1d4ad859dc694eee",
1377+
sha256 = "52763f556d08ba0c0cde1840102e1e5fcf828b98924c4e77f629ad1d7d400933",
13761378
strip_prefix = "emsdk-{version}/bazel",
13771379
urls = ["https://github.com/emscripten-core/emsdk/archive/{version}.tar.gz"],
13781380
use_category = ["test_only"],

0 commit comments

Comments
 (0)