Skip to content

Commit fb4fbd0

Browse files
committed
[TESTING/WIP] ci/coverage: Test proxy-wasm-cpp-sdk PR#157
proxy-wasm/proxy-wasm-cpp-sdk#157 Signed-off-by: Martijn Stevenson <[email protected]>
1 parent 3a43d39 commit fb4fbd0

File tree

3 files changed

+18
-21
lines changed

3 files changed

+18
-21
lines changed

bazel/dependency_imports.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def envoy_dependency_imports(go_version = GO_VERSION, jq_version = JQ_VERSION, y
5858
oss_fuzz = True,
5959
honggfuzz = False,
6060
)
61-
emscripten_deps(emscripten_version = "3.1.7")
61+
emscripten_deps(emscripten_version = "3.1.44")
6262
register_jq_toolchains(version = jq_version)
6363
register_yq_toolchains(version = yq_version)
6464
parser_deps()

bazel/emsdk.patch

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
diff --git a/bazel/emscripten_deps.bzl b/bazel/emscripten_deps.bzl
2-
index 95801ba..95fdabd 100644
2+
index 219cd93..c127d49 100644
33
--- a/bazel/emscripten_deps.bzl
44
+++ b/bazel/emscripten_deps.bzl
5-
@@ -69,31 +69,3 @@ def emscripten_deps(emscripten_version = "latest"):
6-
build_file = "@emsdk//emscripten_toolchain:emscripten.BUILD",
5+
@@ -167,38 +167,3 @@ def emscripten_deps(emscripten_version = "latest"):
6+
build_file_content = BUILD_FILE_CONTENT_TEMPLATE.format(bin_extension = ".exe"),
77
type = "zip",
88
)
99
-
@@ -14,6 +14,13 @@ index 95801ba..95fdabd 100644
1414
- package_lock_json = "@emscripten_bin_linux//:emscripten/package-lock.json",
1515
- )
1616
-
17+
- if "emscripten_npm_linux_arm64" not in excludes:
18+
- npm_install(
19+
- name = "emscripten_npm_linux_arm64",
20+
- package_json = "@emscripten_bin_linux_arm64//:emscripten/package.json",
21+
- package_lock_json = "@emscripten_bin_linux_arm64//:emscripten/package-lock.json",
22+
- )
23+
-
1724
- if "emscripten_npm_mac" not in excludes:
1825
- npm_install(
1926
- name = "emscripten_npm_mac",
@@ -34,15 +41,3 @@ index 95801ba..95fdabd 100644
3441
- package_json = "@emscripten_bin_win//:emscripten/package.json",
3542
- package_lock_json = "@emscripten_bin_win//:emscripten/package-lock.json",
3643
- )
37-
diff --git a/bazel/emscripten_toolchain/BUILD.bazel b/bazel/emscripten_toolchain/BUILD.bazel
38-
index eb36959..12dba37 100644
39-
--- a/bazel/emscripten_toolchain/BUILD.bazel
40-
+++ b/bazel/emscripten_toolchain/BUILD.bazel
41-
@@ -13,7 +13,6 @@ filegroup(
42-
"env.sh",
43-
"env.bat",
44-
"@emsdk//:binaries",
45-
- "@emsdk//:node_modules",
46-
"@nodejs//:node_files",
47-
],
48-
)

bazel/repository_locations.bzl

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1364,12 +1364,13 @@ REPOSITORY_LOCATIONS_SPEC = dict(
13641364
license = "Apache-2.0",
13651365
license_url = "https://github.com/dpkp/kafka-python/blob/{version}/LICENSE",
13661366
),
1367+
# TEST: https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/pull/157/
13671368
proxy_wasm_cpp_sdk = dict(
13681369
project_name = "WebAssembly for Proxies (C++ SDK)",
13691370
project_desc = "WebAssembly for Proxies (C++ SDK)",
13701371
project_url = "https://github.com/proxy-wasm/proxy-wasm-cpp-sdk",
1371-
version = "921039ae983ce053bf5cba78a85a3c08ff9791e5",
1372-
sha256 = "a11adfe4e6346d3318ff72643aa5569dc8439d7e8927ed148f93226fa255cc7a",
1372+
version = "2679d4bddaede88ca48e4cf9f1bdf884adb18bcd",
1373+
sha256 = "04ae5e2bad2c4b281f9874515ddf9d060529f0be3a30911b4c7c7bd73d65ce68",
13731374
strip_prefix = "proxy-wasm-cpp-sdk-{version}",
13741375
urls = ["https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/archive/{version}.tar.gz"],
13751376
use_category = ["dataplane_ext"],
@@ -1430,13 +1431,14 @@ REPOSITORY_LOCATIONS_SPEC = dict(
14301431
license = "Apache-2.0",
14311432
license_url = "https://github.com/proxy-wasm/proxy-wasm-rust-sdk/blob/v{version}/LICENSE",
14321433
),
1434+
# TEST: https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/pull/157/
14331435
emsdk = dict(
14341436
project_name = "Emscripten SDK",
14351437
project_desc = "Emscripten SDK (use by Wasm)",
14361438
project_url = "https://github.com/emscripten-core/emsdk",
1437-
# v3.1.7 with Bazel fixes
1438-
version = "0ea8f8a8707070e9a7c83fbb4a3065683bcf1799",
1439-
sha256 = "1ca0ff918d476c55707bb99bc0452be28ac5fb8f22a9260a8aae8a38d1bc0e27",
1439+
# v3.1.44 with Bazel platforms fixes
1440+
version = "9b0db91883452051aca8deddc932363aab29060b",
1441+
sha256 = "05bad056df1286f920c675504787510434ae8b1b2d83746e0a9b0589429dbe55",
14401442
strip_prefix = "emsdk-{version}/bazel",
14411443
urls = ["https://github.com/emscripten-core/emsdk/archive/{version}.tar.gz"],
14421444
use_category = ["test_only"],

0 commit comments

Comments
 (0)