Fix golangci-lint configuration

Addresses the following errors:

 * Error: can't load config: unsupported version of the configuration: ""
 * Error: can't load config: typecheck is not a linter, it cannot be enabled or disabled
 * Error: can't load config: gofmt is a formatter
 * Error: can't load config: goimports is a formatter
 * Error: unknown linters: 'gosimple,stylecheck,tenv'

Enabling the linter with the existing configs caused it to identify
problems in existing code. These failures are either silenced or fixed.
I only fixed errors that were minor to correct to avoid any larger
refactor to satisfy the linter.

```
7 issues:
* cyclop: 2
* wsl: 2
* errcheck: 3
```

fixup

Author: dekimsey

.golangci.yml

@@ -1,6 +1,22 @@
 ---
+version: 2
 run:
   tests: false
+formatters: 
+  settings:
+    gofmt:
+      # Apply the rewrite rules to the source before reformatting.
+      # https://pkg.go.dev/cmd/gofmt
+      # Default: []
+      rewrite-rules:
+        - pattern: "interface{}"
+          replacement: "any"
+        - pattern: "a[b:len(a)]"
+          replacement: "a[b:]"
+    goimports:
+      # Put imports beginning with prefix after 3rd-party packages.
+      local-prefixes:
+        - github.com/martinbaillie
 
 linters:
   disable-all: true
@@ -24,12 +40,9 @@ linters:
     - gocritic # provides diagnostics that check for bugs, performance and style issues
     - gocyclo # computes and checks the cyclomatic complexity of functions
     - godot # checks if comments end in a period
-    - gofmt # the classic
-    - goimports # in addition to fixing imports, goimports also formats your code in the same style as gofmt
     # - gomnd # detects magic numbers
     - goprintffuncname # checks that printf-like functions are named with f at the end
     - gosec # inspects source code for security problems
-    - gosimple # specializes in simplifying a code
     - govet # reports suspicious constructs, such as Printf calls whose arguments do not align with the format string
     - ineffassign # detects when assignments to existing variables are not used
     # - ireturn # accept interfaces, return concrete types
@@ -47,13 +60,10 @@ linters:
     - reassign # checks that package variables are not reassigned
     - revive # fast, configurable, extensible, flexible, and beautiful linter for Go, drop-in replacement of golint
     - staticcheck # is a go vet on steroids, applying a ton of static analysis checks
-    - stylecheck # is a replacement for golint
     # - tagliatelle # struct tag issues
-    - tenv # detects using os.Setenv instead of t.Setenv since Go1.17
     - testpackage # makes you use a separate _test package
     - thelper # detects golang test helpers without t.Helper() call and checks the consistency of test helpers
     - tparallel # detects inappropriate usage of t.Parallel() method in your Go test codes
-    - typecheck # like the front-end of a Go compiler, parses and type-checks Go code
     - unconvert # removes unnecessary type conversions
     - unparam # reports unused function parameters
     - unused # checks for unused constants, variables, functions and types
@@ -97,10 +107,6 @@ linters-settings:
     allow-cuddle-declarations: true
     allow-assign-and-anything: true
 
-  goimports:
-    # Put imports beginning with prefix after 3rd-party packages.
-    local-prefixes: github.com/martinbaillie
-
   gocritic:
     # The settings key is the name of a supported gocritic checker. The list of
     # supported checkers can be find in https://go-critic.github.io/overview.
@@ -113,16 +119,6 @@ linters-settings:
         # Default: true
         skipRecvDeref: false
 
-  gofmt:
-    # Apply the rewrite rules to the source before reformatting.
-    # https://pkg.go.dev/cmd/gofmt
-    # Default: []
-    rewrite-rules:
-      - pattern: "interface{}"
-        replacement: "any"
-      - pattern: "a[b:len(a)]"
-        replacement: "a[b:]"
-
   gomnd:
     # Magic numbers. List of function patterns to exclude from analysis. Values
     # always ignored: `time.Date` Default: []
@@ -161,7 +157,7 @@ linters-settings:
 
   nolintlint:
     # Exclude following linters from requiring an explanation. Default: []
-    allow-no-explanation: [funlen, gocognit, lll]
+    allow-no-explanation: [ funlen, gocognit, lll ]
     # Enable to require an explanation of nonzero length after each nolint
     # directive. Default: false
     require-explanation: true

flake.nix

@@ -160,9 +160,9 @@
                       if [ -v CI ]; then
                         mkdir -p test
                         ${golangci-lint}/bin/golangci-lint run \
-                            --out-format=checkstyle | tee test/checkstyle.xml
+                            --output.checkstyle.path stdout | tee test/checkstyle.xml
                       else
-                        ${golangci-lint}/bin/golangci-lint run --fast
+                        ${golangci-lint}/bin/golangci-lint run --fast-only
                       fi
                     '';
                   help = "lint the project (heavyweight when CI=true)";

github/client.go

@@ -174,7 +174,7 @@ func (c *Client) Token(ctx context.Context, tokReq *tokenRequest) (*logical.Resp
 	return c.token(ctx, tokReq)
 }
 
-func (c *Client) token(ctx context.Context, tokReq *tokenRequest) (*logical.Response, error) {
+func (c *Client) token(ctx context.Context, tokReq *tokenRequest) (*logical.Response, error) { //nolint:cyclop,funlen
 	accessTokenURL, err := c.accessTokenURLForInstallationID(tokReq.InstallationID)
 	if err != nil {
 		return nil, fmt.Errorf("%s: %w", errUnableToBuildAccessTokenURL, err)
@@ -204,7 +204,7 @@ func (c *Client) token(ctx context.Context, tokReq *tokenRequest) (*logical.Resp
 		return nil, fmt.Errorf("%s: %w", errUnableToCreateAccessToken, err)
 	}
 
-	defer res.Body.Close()
+	defer res.Body.Close() //nolint:errcheck
 
 	if statusCode(res.StatusCode).Unsuccessful() {
 		var bodyBytes []byte
@@ -239,10 +239,11 @@ func (c *Client) token(ctx context.Context, tokReq *tokenRequest) (*logical.Resp
 			resData["repositories"] = repoNames
 		}
 	}
-	tokRes := &logical.Response{Data: resData}
 
 	// Enrich the response with what we know about the installation.
+	tokRes := &logical.Response{Data: resData}
 	tokRes.Data["installation_id"] = tokReq.InstallationID
+
 	if tokReq.OrgName != "" {
 		tokRes.Data["org_name"] = tokReq.OrgName
 	}
@@ -311,8 +312,8 @@ func (c *Client) installationID(ctx context.Context, orgName string) (int, error
 // fetchInstallations makes a request to the GitHub API to fetch the installations.
 func (c *Client) fetchInstallations(ctx context.Context) ([]installation, error) {
 	var allInstallations []installation
-	url := c.installationsURL.String()
 
+	url := c.installationsURL.String()
 	for url != "" {
 		req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
 		if err != nil {
@@ -327,7 +328,7 @@ func (c *Client) fetchInstallations(ctx context.Context) ([]installation, error)
 			return nil, fmt.Errorf("%s: %w", errUnableToGetInstallations, err)
 		}
 
-		defer res.Body.Close()
+		defer res.Body.Close() //nolint:errcheck
 
 		if statusCode(res.StatusCode).Unsuccessful() {
 			var bodyBytes []byte
@@ -409,7 +410,7 @@ func (c *Client) RevokeToken(ctx context.Context, token string) (*logical.Respon
 		return nil, fmt.Errorf("%s: %w", errUnableToRevokeAccessToken, err)
 	}
 
-	defer res.Body.Close()
+	defer res.Body.Close() //nolint:errcheck
 
 	if !statusCode(res.StatusCode).Revoked() {
 		var bodyBytes []byte

github/config.go

@@ -46,7 +46,7 @@ func NewConfig() *Config {
 
 // Update updates the configuration from the given field data only when the data
 // is different.
-func (c *Config) Update(d *framework.FieldData) (bool, error) {
+func (c *Config) Update(d *framework.FieldData) (bool, error) { //nolint:cyclop
 	if d == nil {
 		// NOTE: Use of the path framework ensures `d` is never nil.
 		return false, errFieldDataNil