fix warnings and compilation errors#20
Open
christian-rauch wants to merge 13 commits intomartinruenz:masterfrom
Open
fix warnings and compilation errors#20christian-rauch wants to merge 13 commits intomartinruenz:masterfrom
christian-rauch wants to merge 13 commits intomartinruenz:masterfrom
Conversation
christian-rauch
force-pushed
the
fix_warnings
branch
from
c6532ba to
5abc481
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables some additional warnings as errors and fixes some of these errors (
deprecated,class-memaccess,unused-variable) by replacing C arrays by STL vectors and the deprecated CUDA function__shfl_downwith__shfl_down_sync.I am getting the same results on a simple test sequence. I guess many changes to the
FernsandDeformationfiles are actually not actively used in Co-Fusion.