Skip to content

Commit cdbf140

Browse files
replace special chars in filename before storing an image. #67
1 parent dd5e7b0 commit cdbf140

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

extension/scripts/Scraper.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,9 @@ Scraper.prototype = {
6060

6161
var parts = url.split("/");
6262
var filename = parts[parts.length-1];
63-
filename = filename.split("?")[0];
63+
filename = filename.replace(/\?/g, "%3F");
64+
filename = filename.replace(/=/g, "%3D");
65+
filename = filename.replace(/&/g, "%26");
6466
return filename;
6567
},
6668

tests/spec/ScraperSpec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,8 @@ describe("Scraper", function () {
202202

203203
it("should extract filename from image url with query string", function() {
204204

205-
var image = Scraper.prototype.getFileFilename("http://example.com/image.jpg?123");
206-
expect(image).toEqual("image.jpg");
205+
var image = Scraper.prototype.getFileFilename("http://example.com/image.jpg?a=1&b=2");
206+
expect(image).toEqual("image.jpg%3Fa%3D1%26b%3D2");
207207
});
208208

209209
it("should extract filename from image url without http://", function(){

0 commit comments

Comments
 (0)