Skip to content

Commit 60661b3

Browse files
authored
feat: node 19, drop node 12 (#189)
* feat: node 19, drop node 12 * fix: tests
1 parent 05f036c commit 60661b3

18 files changed

+1378
-1572
lines changed

.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,6 @@ module.exports = {
99
rules: {
1010
'guard-for-in': 0,
1111
'jest/no-conditional-expect': 0,
12+
'unicorn/prefer-module': 0,
1213
},
1314
};

.github/workflows/builds.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ jobs:
1414
strategy:
1515
matrix:
1616
os: [windows-2019, macos-10.15, ubuntu-18.04]
17-
node: [12, 14, 16, 17]
17+
node: [14, 16, 17]
1818
steps:
1919
- uses: actions/checkout@v2
2020
- uses: actions/setup-node@master
2121
with:
2222
node-version: ${{ matrix.node }}
23-
- run: npm i -g pnpm@^6
23+
- run: npm i -g pnpm@^7
2424
- run: pnpm i --frozen-lockfile
2525
env:
2626
npm_config_build_from_source: true
@@ -37,13 +37,13 @@ jobs:
3737
strategy:
3838
matrix:
3939
os: [windows-2019, macos-10.15, ubuntu-20.04]
40-
node: [18]
40+
node: [18, 19]
4141
steps:
4242
- uses: actions/checkout@v2
4343
- uses: actions/setup-node@master
4444
with:
4545
node-version: ${{ matrix.node }}
46-
- run: npm i -g pnpm@^6
46+
- run: npm i -g pnpm@^7
4747
- run: pnpm i --frozen-lockfile
4848
env:
4949
npm_config_build_from_source: true
@@ -59,15 +59,15 @@ jobs:
5959
runs-on: ubuntu-18.04
6060
strategy:
6161
matrix:
62-
node: [12, 14, 16, 17, 18]
62+
node: [14, 16, 17, 18, 19]
6363
fail-fast: true
6464
container:
6565
image: node:${{ matrix.node }}-alpine
6666
steps:
6767
- uses: actions/checkout@v2
6868
- run: |
6969
apk add --no-cache python3 make g++
70-
- run: npm i -g pnpm@^6
70+
- run: npm i -g pnpm@^7
7171
- run: pnpm i --frozen-lockfile
7272
env:
7373
npm_config_build_from_source: true

binding.gyp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
# node-gyp 2.x doesn't add this anymore
7171
# https://github.com/TooTallNate/node-gyp/pull/612
7272
"xcode_settings": {
73-
"CLANG_CXX_LANGUAGE_STANDARD": "c++14",
73+
"CLANG_CXX_LANGUAGE_STANDARD": "c++17",
7474
"OTHER_LDFLAGS": ["-undefined dynamic_lookup"],
7575
},
7676
},

index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { EventEmitter } from 'events';
1+
import { EventEmitter } from 'node:events';
22

33
export const version: string;
44
export const libxml_version: string;

package.json

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"Jeff Smick",
66
"Marco Rogers"
77
],
8-
"packageManager": "pnpm@6.32.9",
8+
"packageManager": "pnpm@7.14.0",
99
"binary": {
1010
"module_name": "xmljs",
1111
"module_path": "./build/Release/",
@@ -14,7 +14,7 @@
1414
"package_name": "{node_abi}-{platform}-{arch}-{libc}.tar.gz"
1515
},
1616
"description": "libxml bindings for v8 javascript engine",
17-
"version": "0.30.1",
17+
"version": "0.31.0",
1818
"scripts": {
1919
"build": "node-pre-gyp install --build-from-source",
2020
"install": "node-pre-gyp install --fallback-to-build --loglevel http",
@@ -45,17 +45,18 @@
4545
"Makefile"
4646
],
4747
"dependencies": {
48-
"@mapbox/node-pre-gyp": "^1.0.9",
48+
"@mapbox/node-pre-gyp": "^1.0.10",
4949
"bindings": "~1.5.0",
50-
"nan": "~2.15.0"
50+
"nan": "~2.17.0"
5151
},
5252
"devDependencies": {
53-
"eslint": "^8.14.0",
54-
"eslint-config-marudor": "^9.0.0",
55-
"jest": "^27.5.1",
56-
"jest-watch-typeahead": "^1.0.0",
57-
"prettier": "^2.6.2",
58-
"tsd": "^0.20.0",
59-
"typescript": "^4.6.3"
53+
"@types/node": "^18.11.3",
54+
"eslint": "^8.26.0",
55+
"eslint-config-marudor": "^9.1.1",
56+
"jest": "^29.2.1",
57+
"jest-watch-typeahead": "^2.2.0",
58+
"prettier": "^2.7.1",
59+
"tsd": "^0.24.1",
60+
"typescript": "^4.8.4"
6061
}
6162
}

0 commit comments

Comments
 (0)