✨ NEW: Add python_install_dev option (#8)

Author: chrisjsewell

README.md

@@ -27,6 +27,8 @@ See `defaults/main.yml`
   roles:
   - role: marvel-nccr.python
     vars:
+      python_base_version: "3.7"
+      python_install_dev: true
       python_venv_path: "/tmp/my_venv"
       python_venv_packages:
         - pip
@@ -35,6 +37,11 @@ See `defaults/main.yml`
       python_venv_state: latest
 ```
 
+## Known Issues
+
+- Python 3.7 is not available on CentOS 8
+- `python_install_dev` and `python_install_tk` will not work for Fedora 31 if no Python 3.7 (`python3-devel` and `python3-tkinter` will be installed, which only work for the default python 3.7 version)
+
 ## Development and testing
 
 This role uses [Molecule](https://molecule.readthedocs.io/en/latest/#) and [Docker](https://www.docker.com/) for tests.

defaults/main.yml

@@ -1,5 +1,7 @@
 root_user: "root"
 python_base_version: "3.7"
+python_install_dev: false  # install libraries and header files needed for Python development
+
 python_venv_path:
 python_venv_state: latest
 python_venv_packages:

molecule/default/molecule.yml

@@ -33,6 +33,7 @@ provisioner:
         vars:
           ansible_python_interpreter: /usr/bin/python3
           python_base_version: "${MOLECULE_PYTHON_VERSION:-3.7}"
-          python_venv_path: /tmp/test_venv
+          python_install_dev: true
           python_install_tk: true
+          python_venv_path: /tmp/test_venv
           run_tests: true

tasks/setup-debian.yml

@@ -23,11 +23,19 @@
     # and for the version of Python specified by this option.
     - python3-setuptools
     - python{{ python_base_version }}
-    - python{{ python_base_version }}-dev
     - python{{ python_base_version }}-venv
     - wget
 
-- name: Install distutils
+- name: Install python{{ python_base_version }}-dev
+  when: python_install_dev|bool
+  become: true
+  become_user: "{{ root_user }}"
+  apt:
+    name:
+    - python{{ python_base_version }}-dev
+
+- name: Install python{{ python_base_version }}-distutils
+  # this is only separate for 18.04
   when: ansible_distribution_major_version|int == 18
   become: true
   become_user: "{{ root_user }}"

tasks/setup-redhat.yml

@@ -4,22 +4,39 @@
   yum:
     update_cache: true
     name:
-    - python{{ python_base_version | replace('.', '') }}
+    - python{{ python_base_version | replace('.', '') }}  # note this also installs venv
     - wget
 
+- name: install development headers
+  when: python_install_dev|bool
+  block:
+  - name: Install python{{ python_base_version }} development headers
+    become: true
+    become_user: "{{ root_user }}"
+    yum:
+      name:
+      - python{{ python_base_version | replace('.', '') }}-devel
+  rescue:
+  - name: Install python3 development headers (fallback)
+    become: true
+    become_user: "{{ root_user }}"
+    yum:
+      name:
+      - python3-devel  # TODO fedora yum does not have python3x-devel available by default
+
 - name: install tkinter
   when: python_install_tk|bool
   block:
-  - name: Install Tk GUI toolkit for python{{ python_base_version | replace('.', '') }}
+  - name: Install Tk GUI toolkit for python{{ python_base_version }}
     become: true
     become_user: "{{ root_user }}"
     yum:
       name:
-      - python{{ python_base_version | replace('.', '') }}-tkinter  # TODO this may not be correct
+      - python{{ python_base_version | replace('.', '') }}-tkinter
   rescue:
   - name: Install Tk GUI toolkit for python3 (fallback)
     become: true
     become_user: "{{ root_user }}"
     yum:
       name:
-      - python3-tkinter
+      - python3-tkinter  # TODO fedora yum does not have python3x-devel available by default