Skip to content

Commit 31640eb

Browse files
fix(core): getNumberFromEnv should return number | undefined (open-telemetry#5874)
1 parent e5c02e7 commit 31640eb

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2
3636
* fix(resource): do not trigger `Accessing resource attributes before async attributes settled` warning when detecting resources [#5546](https://github.com/open-telemetry/opentelemetry-js/pull/5546) @dyladan
3737
* verbose logging of detected resource removed
3838
* fix(resource): use dynamic import over require to improve ESM compliance [#5298](https://github.com/open-telemetry/opentelemetry-js/pull/5298) @xiaoxiangmoe
39+
* fix(core): `getNumberFromEnv` should return number | undefined [#5874](https://github.com/open-telemetry/opentelemetry-js/pull/5874) @shubham-vunet
3940

4041
### :books: Documentation
4142

packages/opentelemetry-core/src/platform/browser/environment.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export function getBooleanFromEnv(_: string): boolean | undefined {
2222
return undefined;
2323
}
2424

25-
export function getNumberFromEnv(_: string): boolean | undefined {
25+
export function getNumberFromEnv(_: string): number | undefined {
2626
return undefined;
2727
}
2828

0 commit comments

Comments
 (0)