Skip to content

Commit 73fe9af

Browse files
committed
changes from feedback
1 parent cb2cd96 commit 73fe9af

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import {
1818
diagLogLevelFromString,
1919
getStringFromEnv,
20-
getStringListFromEnv,
2120
} from '@opentelemetry/core';
2221
import {
2322
ConfigurationModel,

experimental/packages/opentelemetry-configuration/test/ConfigProvider.test.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -214,20 +214,5 @@ describe('ConfigProvider', function () {
214214
defaultConfig
215215
);
216216
});
217-
218-
it('should initialize config with default values from valid config file and node resources', function () {
219-
process.env.OTEL_EXPERIMENTAL_CONFIG_FILE =
220-
'test/fixtures/short-config.yml';
221-
process.env.OTEL_NODE_RESOURCE_DETECTORS = 'env,host, serviceinstance';
222-
const expectedConfig = {
223-
...defaultConfig,
224-
node_resource_detectors: ['env', 'host', 'serviceinstance'],
225-
};
226-
const configProvider = createConfigProvider();
227-
assert.deepStrictEqual(
228-
configProvider.getInstrumentationConfig(),
229-
expectedConfig
230-
);
231-
});
232217
});
233218
});

0 commit comments

Comments
 (0)