Refactored constructor handling for configs

Author: maschmann

Config/Config.php

@@ -61,7 +61,6 @@ public static function factory(array $param, $class = 'ConfigDefault')
      */
     private function __construct()
     {
-
     }
 
     /**
@@ -71,6 +70,5 @@ private function __construct()
      */
     private function __clone()
     {
-
     }
 }

Config/ConfigAbstract.php

@@ -1,6 +1,6 @@
 <?php
 /*
- * This file is part of the <package> package.
+ * This file is part of the php-utilities package.
  *
  * (c) Marc Aschmann <[email protected]>
  *
@@ -30,7 +30,6 @@ abstract class ConfigAbstract extends Data
 
     /**
      * default constructor
-     * calls child's init() method
      *
      * @param array $param
      */
@@ -40,19 +39,9 @@ public function __construct(array $param)
             $this->filecheck = (bool)$param['filecheck'];
         }
 
-        // default init of child class
-        $this->init($param);
+        $this->setConfig($param['file']);
     }
 
-    /**
-     * abstract init
-     * behaves like an interface and enforces implementation in child class
-     *
-     * @abstract
-     * @param array $param
-     */
-    abstract public function init(array $param);
-
     /**
      * add named property to config object
      * and insert config as array

Config/ConfigDefault.php

@@ -17,17 +17,4 @@
  */
 final class ConfigDefault extends ConfigAbstract implements ConfigInterface
 {
-    /**
-     * default method
-     * called by parent::__construct()
-     *
-     * @param  array $param
-     * @return \Asm\Config\ConfigDefault
-     */
-    public function init(array $param)
-    {
-        $this->setConfig($param['file']);
-
-        return $this;
-    }
 }

Config/ConfigEnv.php

@@ -25,21 +25,21 @@ final class ConfigEnv extends ConfigAbstract implements ConfigInterface
     private $defaultEnv = 'prod';
 
     /**
-     * default method
-     * called by parent::__construct()
+     * default constructor
      *
-     * @param  array $param
-     * @return ConfigEnv
+     * @param array $param
      */
-    public function init(array $param)
+    public function __construct(array $param)
     {
+        if (isset($param['filecheck'])) {
+            $this->filecheck = (bool)$param['filecheck'];
+        }
+
         if (!empty($param['defaultEnv'])) {
             $this->defaultEnv = $param['defaultEnv'];
         }
 
         $this->mergeEnvironments($param);
-
-        return $this;
     }
 
     /**

Config/ConfigInterface.php

@@ -21,14 +21,6 @@
  */
 interface ConfigInterface extends DataInterface
 {
-    /**
-     * abstract init
-     * behaves like an interface and enforces implementation in child class
-     *
-     * @param array $param
-     */
-    public function init(array $param);
-
     /**
      * add named property to config object
      * and insert config as array

Config/ConfigTimer.php

@@ -17,20 +17,6 @@
  */
 final class ConfigTimer extends ConfigAbstract implements ConfigInterface
 {
-    /**
-     * default method
-     * called by parent::__construct()
-     *
-     * @param  array $param
-     * @return ConfigTimer
-     */
-    public function init(array $param)
-    {
-        $this->setConfig($param['file']);
-
-        return $this;
-    }
-
     /**
      * convert config date strings to \DateTime objects or \DateIntervals
      *