Replace no-default-lib on AST with Program method, remove no-default-lib support (microsoft#1291)

Author: jakebailey

internal/ast/ast.go

@@ -10012,7 +10012,6 @@ type SourceFile struct {
 	LanguageVariant             core.LanguageVariant
 	ScriptKind                  core.ScriptKind
 	IsDeclarationFile           bool
-	HasNoDefaultLib             bool
 	UsesUriStyleNodeCoreModules core.Tristate
 	Identifiers                 map[string]string
 	IdentifierCount             int
@@ -10138,7 +10137,6 @@ func (node *SourceFile) copyFrom(other *SourceFile) {
 	node.LanguageVariant = other.LanguageVariant
 	node.ScriptKind = other.ScriptKind
 	node.IsDeclarationFile = other.IsDeclarationFile
-	node.HasNoDefaultLib = other.HasNoDefaultLib
 	node.UsesUriStyleNodeCoreModules = other.UsesUriStyleNodeCoreModules
 	node.Identifiers = other.Identifiers
 	node.imports = other.imports

internal/checker/checker.go

@@ -539,6 +539,7 @@ type Program interface {
 	GetImportHelpersImportSpecifier(path tspath.Path) *ast.Node
 	SourceFileMayBeEmitted(sourceFile *ast.SourceFile, forceDtsEmit bool) bool
 	IsSourceFromProjectReference(path tspath.Path) bool
+	IsSourceFileDefaultLibrary(path tspath.Path) bool
 	GetSourceAndProjectReference(path tspath.Path) *tsoptions.SourceAndProjectReference
 	GetRedirectForResolution(file ast.HasFileName) *tsoptions.ParsedCommandLine
 	CommonSourceDirectory() string

internal/checker/relater.go

@@ -587,7 +587,7 @@ func (c *Checker) elaborateElement(source *Type, target *Type, relation *Relatio
 	issuedElaboration := false
 	if targetProp == nil {
 		indexInfo := c.getApplicableIndexInfo(target, nameType)
-		if indexInfo != nil && indexInfo.declaration != nil && !ast.GetSourceFileOfNode(indexInfo.declaration).HasNoDefaultLib {
+		if indexInfo != nil && indexInfo.declaration != nil && !c.program.IsSourceFileDefaultLibrary(ast.GetSourceFileOfNode(indexInfo.declaration).Path()) {
 			issuedElaboration = true
 			diagnostic.AddRelatedInfo(createDiagnosticForNode(indexInfo.declaration, diagnostics.The_expected_type_comes_from_this_index_signature))
 		}
@@ -602,7 +602,7 @@ func (c *Checker) elaborateElement(source *Type, target *Type, relation *Relatio
 		if propertyName == "" || nameType.flags&TypeFlagsUniqueESSymbol != 0 {
 			propertyName = c.TypeToString(nameType)
 		}
-		if !ast.GetSourceFileOfNode(targetNode).HasNoDefaultLib {
+		if !c.program.IsSourceFileDefaultLibrary(ast.GetSourceFileOfNode(targetNode).Path()) {
 			diagnostic.AddRelatedInfo(createDiagnosticForNode(targetNode, diagnostics.The_expected_type_comes_from_property_0_which_is_declared_here_on_type_1, propertyName, c.TypeToString(target)))
 		}
 	}

internal/checker/utilities.go

@@ -1470,7 +1470,7 @@ func forEachYieldExpression(body *ast.Node, visitor func(expr *ast.Node)) {
 func SkipTypeChecking(sourceFile *ast.SourceFile, options *core.CompilerOptions, host Program) bool {
 	return options.NoCheck.IsTrue() ||
 		options.SkipLibCheck.IsTrue() && sourceFile.IsDeclarationFile ||
-		options.SkipDefaultLibCheck.IsTrue() && sourceFile.HasNoDefaultLib ||
+		options.SkipDefaultLibCheck.IsTrue() && host.IsSourceFileDefaultLibrary(sourceFile.Path()) ||
 		host.IsSourceFromProjectReference(sourceFile.Path()) ||
 		!canIncludeBindAndCheckDiagnostics(sourceFile, options)
 }

internal/compiler/fileloader.go

@@ -50,6 +50,7 @@ type processedFiles struct {
 	sourceFileMetaDatas           map[tspath.Path]ast.SourceFileMetaData
 	jsxRuntimeImportSpecifiers    map[tspath.Path]*jsxRuntimeImportSpecifier
 	importHelpersImportSpecifiers map[tspath.Path]*ast.Node
+	libFiles                      collections.Set[tspath.Path]
 	// List of present unsupported extensions
 	unsupportedExtensions                []string
 	sourceFilesFoundSearchingNodeModules collections.Set[tspath.Path]
@@ -130,6 +131,7 @@ func processAllProgramFiles(
 	var importHelpersImportSpecifiers map[tspath.Path]*ast.Node
 	var unsupportedExtensions []string
 	var sourceFilesFoundSearchingNodeModules collections.Set[tspath.Path]
+	var libFileSet collections.Set[tspath.Path]
 
 	loader.parseTasks.collect(&loader, loader.rootTasks, func(task *parseTask, _ []tspath.Path) {
 		if task.isRedirected {
@@ -148,6 +150,7 @@ func processAllProgramFiles(
 		}
 		if task.isLib {
 			libFiles = append(libFiles, file)
+			libFileSet.Add(path)
 		} else {
 			files = append(files, file)
 		}
@@ -197,6 +200,7 @@ func processAllProgramFiles(
 		importHelpersImportSpecifiers:        importHelpersImportSpecifiers,
 		unsupportedExtensions:                unsupportedExtensions,
 		sourceFilesFoundSearchingNodeModules: sourceFilesFoundSearchingNodeModules,
+		libFiles:                             libFileSet,
 	}
 }
 

internal/compiler/program.go

@@ -213,7 +213,6 @@ func (p *Program) initCheckerPool() {
 func canReplaceFileInProgram(file1 *ast.SourceFile, file2 *ast.SourceFile) bool {
 	return file2 != nil &&
 		file1.ParseOptions() == file2.ParseOptions() &&
-		file1.HasNoDefaultLib == file2.HasNoDefaultLib &&
 		file1.UsesUriStyleNodeCoreModules == file2.UsesUriStyleNodeCoreModules &&
 		slices.EqualFunc(file1.Imports(), file2.Imports(), equalModuleSpecifiers) &&
 		slices.EqualFunc(file1.ModuleAugmentations, file2.ModuleAugmentations, equalModuleAugmentationNames) &&
@@ -642,6 +641,10 @@ func (p *Program) GetDefaultResolutionModeForFile(sourceFile ast.HasFileName) co
 	return getDefaultResolutionModeForFile(sourceFile.FileName(), p.sourceFileMetaDatas[sourceFile.Path()], p.projectReferenceFileMapper.getCompilerOptionsForFile(sourceFile))
 }
 
+func (p *Program) IsSourceFileDefaultLibrary(path tspath.Path) bool {
+	return p.libFiles.Has(path)
+}
+
 func (p *Program) CommonSourceDirectory() string {
 	p.commonSourceDirectoryOnce.Do(func() {
 		p.commonSourceDirectory = outputpaths.GetCommonSourceDirectory(

internal/parser/parser.go

@@ -6544,7 +6544,6 @@ func (p *Parser) processPragmasIntoFields(context *ast.SourceFile) {
 	context.TypeReferenceDirectives = nil
 	context.LibReferenceDirectives = nil
 	// context.AmdDependencies = nil
-	context.HasNoDefaultLib = false
 	for _, pragma := range context.Pragmas {
 		switch pragma.Name {
 		case "reference":
@@ -6556,7 +6555,7 @@ func (p *Parser) processPragmasIntoFields(context *ast.SourceFile) {
 			noDefaultLib, noDefaultLibOk := pragma.Args["no-default-lib"]
 			switch {
 			case noDefaultLibOk && noDefaultLib.Value == "true":
-				context.HasNoDefaultLib = true
+				// Ignored.
 			case typesOk:
 				var parsed core.ResolutionMode
 				if resolutionModeOk {

internal/transformers/declarations/transform.go

@@ -196,7 +196,6 @@ func (tx *DeclarationTransformer) transformSourceFile(node *ast.SourceFile) *ast
 	result := tx.Factory().UpdateSourceFile(node, combinedStatements)
 	result.AsSourceFile().LibReferenceDirectives = tx.getLibReferences()
 	result.AsSourceFile().TypeReferenceDirectives = tx.getTypeReferences()
-	result.AsSourceFile().HasNoDefaultLib = node.HasNoDefaultLib
 	result.AsSourceFile().IsDeclarationFile = true
 	result.AsSourceFile().ReferencedFiles = tx.getReferencedFiles(outputFilePath)
 	return result.AsNode()

internal/transformers/tstransforms/importelision_test.go

@@ -156,6 +156,10 @@ func (p *fakeProgram) GetResolvedModules() map[tspath.Path]module.ModeAwareCache
 	panic("unimplemented")
 }
 
+func (p *fakeProgram) IsSourceFileDefaultLibrary(path tspath.Path) bool {
+	return false
+}
+
 func TestImportElision(t *testing.T) {
 	t.Parallel()
 	data := []struct {