migrate IngestDocumentBridge to interface pattern

Author: yaauie

libs/logstash-bridge/src/main/java/org/elasticsearch/logstashbridge/ingest/IngestDocumentBridge.java

@@ -21,80 +21,127 @@
 /**
  * An external bridge for {@link IngestDocument} that proxies calls through a real {@link IngestDocument}
  */
-public class IngestDocumentBridge extends StableBridgeAPI.ProxyInternal<IngestDocument> {
+public interface IngestDocumentBridge extends StableBridgeAPI<IngestDocument> {
 
-    public static final class Constants {
+    MetadataBridge getMetadata();
+
+    Map<String, Object> getSource();
+
+    boolean updateIndexHistory(String index);
+
+    Set<String> getIndexHistory();
+
+    boolean isReroute();
+
+    void resetReroute();
+
+    Map<String, Object> getIngestMetadata();
+
+    <T> T getFieldValue(String name, Class<T> type);
+
+    <T> T getFieldValue(String name, Class<T> type, boolean ignoreMissing);
+
+    String renderTemplate(TemplateScriptBridge.Factory bridgedTemplateScriptFactory);
+
+    void setFieldValue(String path, Object value);
+
+    void removeField(String path);
+
+    void executePipeline(PipelineBridge bridgedPipeline, BiConsumer<IngestDocumentBridge, Exception> bridgedHandler);
+
+    final class Constants {
         public static final String METADATA_VERSION_FIELD_NAME = IngestDocument.Metadata.VERSION.getFieldName();
 
         private Constants() {}
     }
 
-    public static IngestDocumentBridge fromInternalNullable(final IngestDocument ingestDocument) {
+    static IngestDocumentBridge fromInternalNullable(final IngestDocument ingestDocument) {
         if (ingestDocument == null) {
             return null;
         }
-        return new IngestDocumentBridge(ingestDocument);
+        return new IngestDocumentBridge.ProxyInternal(ingestDocument);
     }
 
-    public IngestDocumentBridge(final Map<String, Object> sourceAndMetadata, final Map<String, Object> ingestMetadata) {
-        this(new IngestDocument(sourceAndMetadata, ingestMetadata));
+    static IngestDocumentBridge create(final Map<String, Object> sourceAndMetadata, final Map<String, Object> ingestMetadata) {
+        final IngestDocument internal = new IngestDocument(sourceAndMetadata, ingestMetadata);
+        return fromInternalNullable(internal);
     }
 
-    private IngestDocumentBridge(IngestDocument inner) {
-        super(inner);
-    }
+    class ProxyInternal extends StableBridgeAPI.ProxyInternal<IngestDocument> implements IngestDocumentBridge {
 
-    public MetadataBridge getMetadata() {
-        return new MetadataBridge(internalDelegate.getMetadata());
-    }
+        public ProxyInternal(final Map<String, Object> sourceAndMetadata, final Map<String, Object> ingestMetadata) {
+            this(new IngestDocument(sourceAndMetadata, ingestMetadata));
+        }
 
-    public Map<String, Object> getSource() {
-        return internalDelegate.getSource();
-    }
+        private ProxyInternal(IngestDocument inner) {
+            super(inner);
+        }
 
-    public boolean updateIndexHistory(final String index) {
-        return internalDelegate.updateIndexHistory(index);
-    }
+        @Override
+        public MetadataBridge getMetadata() {
+            return new MetadataBridge(internalDelegate.getMetadata());
+        }
 
-    public Set<String> getIndexHistory() {
-        return Set.copyOf(internalDelegate.getIndexHistory());
-    }
+        @Override
+        public Map<String, Object> getSource() {
+            return internalDelegate.getSource();
+        }
 
-    public boolean isReroute() {
-        return LogstashInternalBridge.isReroute(internalDelegate);
-    }
+        @Override
+        public boolean updateIndexHistory(final String index) {
+            return internalDelegate.updateIndexHistory(index);
+        }
 
-    public void resetReroute() {
-        LogstashInternalBridge.resetReroute(internalDelegate);
-    }
+        @Override
+        public Set<String> getIndexHistory() {
+            return Set.copyOf(internalDelegate.getIndexHistory());
+        }
 
-    public Map<String, Object> getIngestMetadata() {
-        return internalDelegate.getIngestMetadata();
-    }
+        @Override
+        public boolean isReroute() {
+            return LogstashInternalBridge.isReroute(internalDelegate);
+        }
 
-    public <T> T getFieldValue(final String fieldName, final Class<T> type) {
-        return internalDelegate.getFieldValue(fieldName, type);
-    }
+        @Override
+        public void resetReroute() {
+            LogstashInternalBridge.resetReroute(internalDelegate);
+        }
 
-    public <T> T getFieldValue(final String fieldName, final Class<T> type, final boolean ignoreMissing) {
-        return internalDelegate.getFieldValue(fieldName, type, ignoreMissing);
-    }
+        @Override
+        public Map<String, Object> getIngestMetadata() {
+            return internalDelegate.getIngestMetadata();
+        }
 
-    public String renderTemplate(final TemplateScriptBridge.Factory templateScriptFactory) {
-        return internalDelegate.renderTemplate(templateScriptFactory.toInternal());
-    }
+        @Override
+        public <T> T getFieldValue(final String fieldName, final Class<T> type) {
+            return internalDelegate.getFieldValue(fieldName, type);
+        }
 
-    public void setFieldValue(final String path, final Object value) {
-        internalDelegate.setFieldValue(path, value);
-    }
+        @Override
+        public <T> T getFieldValue(final String fieldName, final Class<T> type, final boolean ignoreMissing) {
+            return internalDelegate.getFieldValue(fieldName, type, ignoreMissing);
+        }
 
-    public void removeField(final String path) {
-        internalDelegate.removeField(path);
-    }
+        @Override
+        public String renderTemplate(final TemplateScriptBridge.Factory templateScriptFactory) {
+            return internalDelegate.renderTemplate(templateScriptFactory.toInternal());
+        }
 
-    public void executePipeline(final PipelineBridge pipelineBridge, final BiConsumer<IngestDocumentBridge, Exception> handler) {
-        this.internalDelegate.executePipeline(pipelineBridge.toInternal(), (ingestDocument, e) -> {
-            handler.accept(IngestDocumentBridge.fromInternalNullable(ingestDocument), e);
-        });
+        @Override
+        public void setFieldValue(final String path, final Object value) {
+            internalDelegate.setFieldValue(path, value);
+        }
+
+        @Override
+        public void removeField(final String path) {
+            internalDelegate.removeField(path);
+        }
+
+        @Override
+        public void executePipeline(final PipelineBridge pipelineBridge, final BiConsumer<IngestDocumentBridge, Exception> handler) {
+            this.internalDelegate.executePipeline(pipelineBridge.toInternal(), (ingestDocument, e) -> {
+                handler.accept(IngestDocumentBridge.fromInternalNullable(ingestDocument), e);
+            });
+        }
     }
 }