fix: use absolute paths for subprocess commands in pathbrowser utils

Author: mashu3

tests/test_pathbrowser.py

@@ -282,37 +282,65 @@ def test_open_file_with_default_app_macos(self):
             with patch('tkface.widget.pathbrowser.utils.IS_WINDOWS', False):
                 with patch('tkface.widget.pathbrowser.utils.IS_LINUX', False):
                     with patch('tkface.widget.pathbrowser.utils.subprocess.run') as mock_run:
-                        result = utils.open_file_with_default_app("/test/file.txt")
-                        assert result is True
-                        mock_run.assert_called_once_with(["open", "/test/file.txt"], check=False)
+                        with patch('tkface.widget.pathbrowser.utils.shutil.which') as mock_which:
+                            mock_which.return_value = "/usr/bin/open"
+                            result = utils.open_file_with_default_app("/test/file.txt")
+                            assert result is True
+                            mock_run.assert_called_once_with(["/usr/bin/open", "/test/file.txt"], check=False)
 
     def test_open_file_with_default_app_macos_exception(self):
         """Test open_file_with_default_app function on macOS with exception."""
         with patch('tkface.widget.pathbrowser.utils.IS_MACOS', True):
             with patch('tkface.widget.pathbrowser.utils.IS_WINDOWS', False):
                 with patch('tkface.widget.pathbrowser.utils.IS_LINUX', False):
                     with patch('tkface.widget.pathbrowser.utils.subprocess.run') as mock_run:
-                        mock_run.side_effect = Exception("Command not found")
-                        result = utils.open_file_with_default_app("/test/file.txt")
-                        assert result is False
+                        with patch('tkface.widget.pathbrowser.utils.shutil.which') as mock_which:
+                            mock_which.return_value = "/usr/bin/open"
+                            mock_run.side_effect = Exception("Command not found")
+                            result = utils.open_file_with_default_app("/test/file.txt")
+                            assert result is False
 
     def test_open_file_with_default_app_linux(self):
         """Test open_file_with_default_app function on Linux."""
         with patch('tkface.widget.pathbrowser.utils.IS_LINUX', True):
             with patch('tkface.widget.pathbrowser.utils.IS_WINDOWS', False):
                 with patch('tkface.widget.pathbrowser.utils.IS_MACOS', False):
                     with patch('tkface.widget.pathbrowser.utils.subprocess.run') as mock_run:
-                        result = utils.open_file_with_default_app("/test/file.txt")
-                        assert result is True
-                        mock_run.assert_called_once_with(["xdg-open", "/test/file.txt"], check=False)
+                        with patch('tkface.widget.pathbrowser.utils.shutil.which') as mock_which:
+                            mock_which.return_value = "/usr/bin/xdg-open"
+                            result = utils.open_file_with_default_app("/test/file.txt")
+                            assert result is True
+                            mock_run.assert_called_once_with(["/usr/bin/xdg-open", "/test/file.txt"], check=False)
 
     def test_open_file_with_default_app_linux_exception(self):
         """Test open_file_with_default_app function on Linux with exception."""
         with patch('tkface.widget.pathbrowser.utils.IS_LINUX', True):
             with patch('tkface.widget.pathbrowser.utils.IS_WINDOWS', False):
                 with patch('tkface.widget.pathbrowser.utils.IS_MACOS', False):
                     with patch('tkface.widget.pathbrowser.utils.subprocess.run') as mock_run:
-                        mock_run.side_effect = Exception("Command not found")
+                        with patch('tkface.widget.pathbrowser.utils.shutil.which') as mock_which:
+                            mock_which.return_value = "/usr/bin/xdg-open"
+                            mock_run.side_effect = Exception("Command not found")
+                            result = utils.open_file_with_default_app("/test/file.txt")
+                            assert result is False
+
+    def test_open_file_with_default_app_macos_command_not_found(self):
+        """Test open_file_with_default_app function on macOS when command not found."""
+        with patch('tkface.widget.pathbrowser.utils.IS_MACOS', True):
+            with patch('tkface.widget.pathbrowser.utils.IS_WINDOWS', False):
+                with patch('tkface.widget.pathbrowser.utils.IS_LINUX', False):
+                    with patch('tkface.widget.pathbrowser.utils.shutil.which') as mock_which:
+                        mock_which.return_value = None
+                        result = utils.open_file_with_default_app("/test/file.txt")
+                        assert result is False
+
+    def test_open_file_with_default_app_linux_command_not_found(self):
+        """Test open_file_with_default_app function on Linux when command not found."""
+        with patch('tkface.widget.pathbrowser.utils.IS_LINUX', True):
+            with patch('tkface.widget.pathbrowser.utils.IS_WINDOWS', False):
+                with patch('tkface.widget.pathbrowser.utils.IS_MACOS', False):
+                    with patch('tkface.widget.pathbrowser.utils.shutil.which') as mock_which:
+                        mock_which.return_value = None
                         result = utils.open_file_with_default_app("/test/file.txt")
                         assert result is False
 

tkface/widget/pathbrowser/utils.py

@@ -7,6 +7,7 @@
 
 import fnmatch
 import os
+import shutil
 import subprocess
 import sys
 from pathlib import Path
@@ -56,9 +57,17 @@ def open_file_with_default_app(file_path: str) -> bool:
         if IS_WINDOWS:
             os.startfile(file_path)  # pylint: disable=no-member
         elif IS_MACOS:
-            subprocess.run(["open", file_path], check=False)
+            open_cmd = shutil.which("open")
+            if open_cmd:
+                subprocess.run([open_cmd, file_path], check=False)
+            else:
+                return False
         else:
-            subprocess.run(["xdg-open", file_path], check=False)
+            xdg_open_cmd = shutil.which("xdg-open")
+            if xdg_open_cmd:
+                subprocess.run([xdg_open_cmd, file_path], check=False)
+            else:
+                return False
         return True
     except Exception:
         return False