fix: replace bare except and try-except-pass with proper exception handling

Author: mashu3

examples/demo_timepicker.py

@@ -614,8 +614,9 @@ def _install_field_debug(self, name, entry_widget, tk_var):
         # Ensure the widget can take focus when clicked
         try:
             entry_widget.configure(takefocus=1)
-        except Exception:  # pylint: disable=broad-except
-            pass
+        except Exception as exc:  # pylint: disable=broad-except
+            # Log configuration failure for debugging
+            self.logger.debug("Failed to configure takefocus for %s: %s", name, exc)
 
         def log_evt(evt_name, event):
             try:
@@ -633,8 +634,9 @@ def on_button1(event):
             try:
                 entry_widget.focus_force()
                 entry_widget.after_idle(entry_widget.focus_force)
-            except Exception:
-                pass
+            except Exception as exc:
+                # Log focus failure for debugging
+                self.logger.debug("Failed to force focus for %s: %s", name, exc)
             log_evt("Button-1", event)
 
         entry_widget.bind("<Button-1>", on_button1, add="+")
@@ -644,8 +646,9 @@ def on_focus_in(event):
             try:
                 entry_widget.select_range(0, tk.END)
                 entry_widget.icursor(tk.END)
-            except Exception:
-                pass
+            except Exception as exc:
+                # Log selection failure for debugging
+                self.logger.debug("Failed to select range for %s: %s", name, exc)
 
         entry_widget.bind("<FocusIn>", on_focus_in, add="+")
 

tests/conftest.py

@@ -58,29 +58,23 @@ def root():
         if "DISPLAY" not in os.environ:
             os.environ["DISPLAY"] = ":0.0"
 
-        # Set TCL_LIBRARY environment variable to help with Tcl initialization
+        # Get the actual Tcl library path from a working Tkinter instance
         import sys
-        if hasattr(sys, 'frozen'):
-            # Running as compiled executable
-            tcl_dir = os.path.join(os.path.dirname(sys.executable), 'tcl', 'tcl8.6')
-        else:
-            # Running as script
+        try:
+            # Create a temporary root to get the actual Tcl library path
+            temp_check = tk.Tk()
+            actual_tcl_library = temp_check.tk.eval('info library')
+            temp_check.destroy()
+            
+            # Set the environment variable to the actual path
+            os.environ["TCL_LIBRARY"] = actual_tcl_library
+            logging.debug(f"Set TCL_LIBRARY to: {actual_tcl_library}")
+        except Exception as e:
+            logging.warning(f"Could not determine Tcl library path: {e}")
+            # Fallback to default paths
             tcl_dir = os.path.join(os.path.dirname(sys.executable), 'tcl', 'tcl8.6')
-        
-        # Try to find Tcl library directory
-        if os.path.exists(tcl_dir):
-            os.environ["TCL_LIBRARY"] = tcl_dir
-        else:
-            # Try alternative paths
-            alternative_paths = [
-                os.path.join(os.path.dirname(sys.executable), 'tcl', 'tcl8.6'),
-                os.path.join(os.path.dirname(sys.executable), '..', 'tcl', 'tcl8.6'),
-                os.path.join(os.path.dirname(sys.executable), '..', '..', 'tcl', 'tcl8.6'),
-            ]
-            for alt_path in alternative_paths:
-                if os.path.exists(alt_path):
-                    os.environ["TCL_LIBRARY"] = alt_path
-                    break
+            if os.path.exists(tcl_dir):
+                os.environ["TCL_LIBRARY"] = tcl_dir
 
         # Create new root window for each test
         temp_root = tk.Tk()
@@ -146,8 +140,9 @@ def root():
         # Try cleanup for unexpected errors
         try:
             temp_root.destroy()
-        except:
-            pass
+        except Exception as exc:
+            # Log cleanup failure for debugging
+            logging.debug("Failed to destroy temp root during cleanup: %s", exc)
         raise
 
 
@@ -170,29 +165,23 @@ def root_function():
         if "DISPLAY" not in os.environ:
             os.environ["DISPLAY"] = ":0.0"
 
-        # Set TCL_LIBRARY environment variable to help with Tcl initialization
+        # Get the actual Tcl library path from a working Tkinter instance
         import sys
-        if hasattr(sys, 'frozen'):
-            # Running as compiled executable
-            tcl_dir = os.path.join(os.path.dirname(sys.executable), 'tcl', 'tcl8.6')
-        else:
-            # Running as script
+        try:
+            # Create a temporary root to get the actual Tcl library path
+            temp_check = tk.Tk()
+            actual_tcl_library = temp_check.tk.eval('info library')
+            temp_check.destroy()
+            
+            # Set the environment variable to the actual path
+            os.environ["TCL_LIBRARY"] = actual_tcl_library
+            logging.debug(f"Set TCL_LIBRARY to: {actual_tcl_library}")
+        except Exception as e:
+            logging.warning(f"Could not determine Tcl library path: {e}")
+            # Fallback to default paths
             tcl_dir = os.path.join(os.path.dirname(sys.executable), 'tcl', 'tcl8.6')
-        
-        # Try to find Tcl library directory
-        if os.path.exists(tcl_dir):
-            os.environ["TCL_LIBRARY"] = tcl_dir
-        else:
-            # Try alternative paths
-            alternative_paths = [
-                os.path.join(os.path.dirname(sys.executable), 'tcl', 'tcl8.6'),
-                os.path.join(os.path.dirname(sys.executable), '..', 'tcl', 'tcl8.6'),
-                os.path.join(os.path.dirname(sys.executable), '..', '..', 'tcl', 'tcl8.6'),
-            ]
-            for alt_path in alternative_paths:
-                if os.path.exists(alt_path):
-                    os.environ["TCL_LIBRARY"] = alt_path
-                    break
+            if os.path.exists(tcl_dir):
+                os.environ["TCL_LIBRARY"] = tcl_dir
 
         # Create new root window
         temp_root = tk.Tk()

tests/test_dpi.py

@@ -7,6 +7,7 @@
 
 import contextlib
 import ctypes
+import logging
 import sys
 import types
 from ctypes import wintypes
@@ -681,8 +682,9 @@ def wrapper(self, *args, **kwargs):
                                 # Create a new root
                                 root = tk.Tk()
                                 root.withdraw()
-                        except:
+                        except Exception as exc:
                             # If there's any issue, try to create a new root
+                            logging.debug("Failed to use existing root, creating new one: %s", exc)
                             root = tk.Tk()
                             root.withdraw()
 
@@ -4084,9 +4086,10 @@ def test_patch_layout_method_error_handling(self):
         # This should not raise an exception
         try:
             manager._patch_layout_method("test.method", original_method, 2.0)
-        except Exception:
+        except Exception as exc:
             # If it raises an exception, that's also acceptable for error handling
-            pass
+            # Log the exception for debugging purposes
+            logging.debug("Expected exception in _patch_layout_method: %s", exc)
 
     def test_patch_widget_constructor_error_handling(self):
         """Test _patch_widget_constructor error handling."""
@@ -4101,9 +4104,10 @@ def test_patch_widget_constructor_error_handling(self):
         # This should not raise an exception
         try:
             manager._patch_widget_constructor(mock_widget_class, 2.0, "test.method")
-        except Exception:
+        except Exception as exc:
             # If it raises an exception, that's also acceptable for error handling
-            pass
+            # Log the exception for debugging purposes
+            logging.debug("Expected exception in _patch_widget_constructor: %s", exc)
 
     def test_patch_treeview_method_error_handling(self):
         """Test _patch_treeview_method error handling."""
@@ -4118,9 +4122,10 @@ def test_patch_treeview_method_error_handling(self):
         # This should not raise an exception
         try:
             manager._patch_treeview_method("test.method", original_method, 2.0, MagicMock())
-        except Exception:
+        except Exception as exc:
             # If it raises an exception, that's also acceptable for error handling
-            pass
+            # Log the exception for debugging purposes
+            logging.debug("Expected exception in _patch_treeview_method: %s", exc)
 
     def test_patch_treeview_method_bound_method_handling(self):
         """Test _patch_treeview_method with bound method."""
@@ -4140,9 +4145,10 @@ def test_patch_treeview_method_bound_method_handling(self):
         # This should not raise an exception
         try:
             manager._patch_treeview_method("test.method", bound_method, 2.0, MagicMock())
-        except Exception:
+        except Exception as exc:
             # If it raises an exception, that's also acceptable for error handling
-            pass
+            # Log the exception for debugging purposes
+            logging.debug("Expected exception in _patch_treeview_method (bound): %s", exc)
 
     def test_patch_treeview_method_unbound_method_handling(self):
         """Test _patch_treeview_method with unbound method."""
@@ -4158,9 +4164,10 @@ def test_patch_treeview_method_unbound_method_handling(self):
         # This should not raise an exception
         try:
             manager._patch_treeview_method("ttk.Treeview.column", unbound_method, 2.0, MagicMock())
-        except Exception:
+        except Exception as exc:
             # If it raises an exception, that's also acceptable for error handling
-            pass
+            # Log the exception for debugging purposes
+            logging.debug("Expected exception in _patch_treeview_method (unbound): %s", exc)
 
     def test_patch_treeview_method_style_class_handling(self):
         """Test _patch_treeview_method with Style class."""
@@ -4176,9 +4183,10 @@ def test_patch_treeview_method_style_class_handling(self):
         # This should not raise an exception
         try:
             manager._patch_treeview_method("ttk.Style.configure", unbound_method, 2.0, MagicMock())
-        except Exception:
+        except Exception as exc:
             # If it raises an exception, that's also acceptable for error handling
-            pass
+            # Log the exception for debugging purposes
+            logging.debug("Expected exception in _patch_treeview_method (Style): %s", exc)
 
     def test_scale_layout_spec_recursive_children_scaling(self):
         """Test recursive layout spec scaling with children."""