Buffer is sometimes attached to tsserver with the wrong root_dir when using a mono repo

[darcyparker]

I have a mono repo (typescript, with workspaces).

• project/packages (each package has its own package.json and tsconfig.json)
• src/

The project's package.json has:

{
  "private": true,
  "workspaces": [
    "packages/*"
  ],
  ....
}

The project has a tsconfig.base.json and it's tsconfig.json extends it.
As well, each package has its own tsconfig.json that extends the ../../tsconfig.base.json and adds composite: true in the compilerOptions.

After upgrading to typescript 5.1.6 (from 4.x), I started having problems with this mono repo. I feel it is something to do with nvim and my nvim configuration, because the issues do not occur with vscode. It also seems to be something new with moving to typescript 5.x.

If I do a fresh start of nvim and the first buffer I open is in one of the packages, then the lsp client (tsserver) the buffer attaches to has the correct root_dir set to project/packages/<packagename>. Then if the second buffer I open is in /src, a second lsp client (tsserver) is started with the correct root_dir set to project. In this case, everything is good... The types are all available and I can go to definition correctly from each buffer.

But, if I start fresh, and open a file in /src, and then open another buffer (for example with go to definition) that is in one of the project/packages, there is only 1 LSP client that the 2 buffers are attached to. I think they should be separate clients, because the buffer for the project/packages/<packagename> can't resolve its types properly... and it seems to be reading the wrong tsconfig.json.

I want nvim to create a new lsp client when needed with the correct root_dir so that it can resolve the modules correctly. What can I do to ensure the correct root_dir is set when a buffer is opened?

[darcyparker]

To help debug, I added:

root_dir = function(fname)
  local dir = util.root_pattern('package.json', 'tsconfig.json', 'jsconfig.json', '.git')(fname);
  vim.notify('setting root_dir' .. dir);
  return dir
end,

and I am getting the expected dir from vim.notify when I change buffers. But :LspInfo is not showing a tsserver client for that root_dir.