Skip to content

Commit 69233c4

Browse files
Apply CR comments
1 parent eb2866a commit 69233c4

File tree

4 files changed

+8
-31
lines changed

4 files changed

+8
-31
lines changed

.github/workflows/plugin-release.yml

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,6 @@ jobs:
4242
fi
4343
echo "Manifest version matches input version: $version"
4444
45-
extract-version:
46-
runs-on: ubuntu-latest
47-
needs: check-manifest
48-
outputs:
49-
version: ${{ inputs.version }}
50-
steps:
51-
- name: Set version
52-
id: get-version
53-
run: |
54-
echo "version=${{ inputs.version }}" >> $GITHUB_OUTPUT
55-
echo "Plugin Version: ${{ inputs.version }}"
56-
5745
build-plugin:
5846
uses: ./.github/workflows/plugin.yml
5947
needs: check-manifest
@@ -62,7 +50,7 @@ jobs:
6250
secrets: inherit
6351

6452
create-release:
65-
needs: [check-manifest, extract-version, build-plugin]
53+
needs: [check-manifest, build-plugin]
6654
runs-on: ubuntu-latest
6755
permissions:
6856
contents: write
@@ -96,8 +84,8 @@ jobs:
9684
- name: Create Release
9785
uses: softprops/action-gh-release@v2
9886
with:
99-
tag_name: plugin-v${{ needs.extract-version.outputs.version }}
100-
name: plugin v${{ needs.extract-version.outputs.version }}
87+
tag_name: plugin-v${{ inputs.version }}
88+
name: plugin v${{ inputs.version }}
10189
draft: ${{ inputs.release-as-draft }}
10290
prerelease: ${{ inputs.release-as-prerelease }}
10391
generate_release_notes: ${{ inputs.generate-release-notes }}

.github/workflows/plugin.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
working-directory: ./plugin
5050

5151
- name: Install gofumpt
52-
run: go install mvdan.cc/gofumpt@latest
52+
run: go install mvdan.cc/gofumpt@0.7.0
5353

5454
- name: Run gofumpt
5555
run: |

.github/workflows/server-release.yml

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,25 +24,14 @@ on:
2424
default: true
2525

2626
jobs:
27-
extract-version:
28-
runs-on: ubuntu-latest
29-
outputs:
30-
version: ${{ inputs.version }}
31-
steps:
32-
- name: Set version
33-
id: get-version
34-
run: |
35-
echo "version=${{ inputs.version }}" >> $GITHUB_OUTPUT
36-
echo "Server Version: ${{ inputs.version }}"
37-
3827
build-server:
3928
uses: ./.github/workflows/server.yml
4029
with:
4130
version: ${{ inputs.version }}
4231
secrets: inherit
4332

4433
create-release:
45-
needs: [extract-version, build-server]
34+
needs: build-server
4635
runs-on: ubuntu-latest
4736
permissions:
4837
contents: write
@@ -59,8 +48,8 @@ jobs:
5948
- name: Create Release
6049
uses: softprops/action-gh-release@v2
6150
with:
62-
tag_name: v${{ needs.extract-version.outputs.version }}
63-
name: server v${{ needs.extract-version.outputs.version }}
51+
tag_name: v${{ inputs.version }}
52+
name: server v${{ inputs.version }}
6453
draft: ${{ inputs.release-as-draft }}
6554
prerelease: ${{ inputs.release-as-prerelease }}
6655
generate_release_notes: ${{ inputs.generate-release-notes }}

.github/workflows/server.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
working-directory: ./server
4545

4646
- name: Install gofumpt
47-
run: go install mvdan.cc/gofumpt@latest
47+
run: go install mvdan.cc/gofumpt@0.7.0
4848

4949
- name: Run gofumpt
5050
run: |

0 commit comments

Comments
 (0)