Merge branch 'main' into fix-cd

Author: yvan-sraka

.github/workflows/cd.yml

@@ -10,8 +10,6 @@ env:
   RUST_BACKTRACE: full
 
 jobs:
-  # The 3 following build jobs are 90% copy-pasted and should be refactored using
-  # https://docs.github.com/en/actions/creating-actions/creating-a-composite-action
   release:
     strategy:
       matrix:
@@ -63,4 +61,4 @@ jobs:
       - name: Publish
         uses: softprops/action-gh-release@v1
         with:
-            files: 'release_*'
+            files: 'release_*'

.github/workflows/ci-light.yml

@@ -21,7 +21,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           components: rustfmt
           override: true
       - uses: Swatinem/rust-cache@v1
@@ -41,7 +41,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           override: true
       - uses: Swatinem/rust-cache@v1
       - uses: actions-rs/cargo@v1
@@ -60,7 +60,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           components: clippy
           override: true
       - uses: Swatinem/rust-cache@v1

.github/workflows/ci.yml

@@ -21,7 +21,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           components: rustfmt
           override: true
       - uses: Swatinem/rust-cache@v1
@@ -41,7 +41,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           override: true
       - uses: Swatinem/rust-cache@v1
       - uses: actions-rs/cargo@v1
@@ -59,7 +59,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           override: true
       - uses: Swatinem/rust-cache@v1
       - uses: actions-rs/cargo@v1
@@ -78,7 +78,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           override: true
       - uses: Swatinem/rust-cache@v1
       - uses: actions-rs/cargo@v1
@@ -98,7 +98,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           components: clippy
           override: true
       - uses: Swatinem/rust-cache@v1
@@ -126,7 +126,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           override: true
       - uses: Swatinem/rust-cache@v1
       - uses: actions-rs/cargo@v1
@@ -151,7 +151,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           override: true
       - uses: actions-rs/cargo@v1
         with:
@@ -184,7 +184,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: nightly
+          toolchain: nightly-2021-12-03
           components: rustfmt
           override: true
       - uses: actions-rs/cargo@v1

.github/workflows/stale.yml

@@ -0,0 +1,27 @@
+# This workflow warns and then closes issues and PRs that have had no activity for a specified amount of time.
+#
+# You can adjust the behavior by modifying this file.
+# For more information, see:
+# https://github.com/actions/stale
+name: Mark stale issues and pull requests
+
+on:
+  schedule:
+  - cron: '22 18 * * *'
+
+jobs:
+  stale:
+
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+      pull-requests: write
+
+    steps:
+    - uses: actions/stale@v3
+      with:
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+        stale-issue-message: 'Stale issue message'
+        stale-pr-message: 'Stale pull request message'
+        stale-issue-label: 'no-issue-activity'
+        stale-pr-label: 'no-pr-activity'

massa-client/src/cmds.rs

@@ -612,14 +612,18 @@ impl Command {
             }
             Command::when_episode_ends => {
                 let end = match client.public.get_status().await {
-                    Ok(node_status) => node_status.consensus_stats.end_timespan,
+                    Ok(node_status) => node_status.config.end_timestamp,
                     Err(e) => bail!("RpcError: {}", e),
                 };
-                let (days, hours, mins, secs) = end
-                    .saturating_sub(MassaTime::now()?)
-                    .days_hours_mins_secs()?; // compensation millis is zero
                 let mut res = "".to_string();
-                res.push_str(&format!("{} days, {} hours, {} minutes, {} seconds remaining until the end of the current episode", days, hours, mins, secs));
+                if let Some(e) = end {
+                    let (days, hours, mins, secs) =
+                        e.saturating_sub(MassaTime::now()?).days_hours_mins_secs()?; // compensation millis is zero
+
+                    res.push_str(&format!("{} days, {} hours, {} minutes, {} seconds remaining until the end of the current episode", days, hours, mins, secs));
+                } else {
+                    res.push_str("There is no end !")
+                }
                 if !json {
                     println!("{}", res);
                 }

massa-consensus/endorsements.md

@@ -2,7 +2,7 @@
 
 ## Goal
 
-Endorsements are included in a block's header. They are created by randomly selected endorsers chosen amon the stakers (including the block creator) to endorse the block's parent in the same thread. The block's total fee and reward are split between the block creator, the endorsers, and the creator of the endorsed block.
+Endorsements are included in a block's header. They are created by randomly selected endorsers chosen among the stakers (including the block creator) to endorse the block's parent in the same thread. The block's total fee and reward are split between the block creator, the endorsers, and the creator of the endorsed block.
 
 With that mechanism it becomes harder to gain control of the network (you now have to control `endorsement_count + 1` draw to gain control over one block) and to reward stakers more frequently.
 

massa-consensus/src/block_graph.rs

@@ -51,35 +51,35 @@ impl HeaderOrBlock {
     }
 }
 
-/// Agregated changes made during a block's execution
+/// Aggregated changes made during a block's execution
 #[derive(Debug, Clone)]
 pub struct BlockStateAccumulator {
     /// Addresses impacted by ledger updates
     pub loaded_ledger_addrs: AddressHashSet,
     /// Subset of the ledger. Contains only data in the thread of the given block
     pub ledger_thread_subset: LedgerSubset,
-    /// Cummulative changes made during that block execution
+    /// Cumulative changes made during that block execution
     pub ledger_changes: LedgerChanges,
     /// Addresses impacted by roll updates
     pub loaded_roll_addrs: AddressHashSet,
     /// Current roll counts for these addresses
     pub roll_counts: RollCounts,
     /// Roll updates that happened during that block execution
     pub roll_updates: RollUpdates,
-    /// Roll updates that happend during current cycle
+    /// Roll updates that happened during current cycle
     pub cycle_roll_updates: RollUpdates,
     /// Cycle of the parent in the same thread
     pub same_thread_parent_cycle: u64,
     /// Address of the parent in the same thread
     pub same_thread_parent_creator: Address,
-    /// Adresses of that block endorsers
+    /// Addresses of that block endorsers
     pub endorsers_addresses: Vec<Address>,
 }
 
 /// Block that was checked as final, with some useful precomputed data
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct ActiveBlock {
-    /// The cretor's address
+    /// The creator's address
     pub creator_address: Address,
     /// The block itself, as it was created
     pub block: Block,
@@ -92,7 +92,7 @@ pub struct ActiveBlock {
     pub dependencies: BlockHashSet,
     /// Blocks id that have this block as an ancestor
     pub descendants: BlockHashSet,
-    /// ie has its fitness reached the given thresold
+    /// ie has its fitness reached the given threshold
     pub is_final: bool,
     /// Changes caused by this block
     pub block_ledger_changes: LedgerChanges,
@@ -118,7 +118,7 @@ impl ActiveBlock {
 }
 
 /// Exportable version of ActiveBlock
-/// Fields that can be easily recomuted were left out
+/// Fields that can be easily recomputed were left out
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct ExportActiveBlock {
     /// The block itself, as it was created
@@ -130,7 +130,7 @@ pub struct ExportActiveBlock {
     pub children: Vec<BlockHashMap<u64>>,
     /// dependencies required for validity check
     pub dependencies: BlockHashSet,
-    /// ie has its fitness reached the given thresold
+    /// ie has its fitness reached the given threshold
     pub is_final: bool,
     /// Changes caused by this block
     pub block_ledger_changes: LedgerChanges,
@@ -1195,7 +1195,7 @@ impl BlockGraph {
         })
     }
 
-    /// Try to apply an operation in the contexxt of the block
+    /// Try to apply an operation in the context of the block
     ///
     /// # Arguments
     /// * state_accu: where the changes are accumulated while we go through the block
@@ -1566,7 +1566,7 @@ impl BlockGraph {
         Ok(accu)
     }
 
-    /// Gets lastest final blocks (hash, period) for each thread.
+    /// Gets latest final blocks (hash, period) for each thread.
     pub fn get_latest_final_blocks_periods(&self) -> &Vec<(BlockId, u64)> {
         &self.latest_final_blocks_periods
     }
@@ -1736,7 +1736,7 @@ impl BlockGraph {
         Ok((cur_rolls, cur_cycle_roll_updates))
     }
 
-    /// gets Ledger data export for given Addressses
+    /// gets Ledger data export for given Addressees
     pub fn get_ledger_data_export(
         &self,
         addresses: &AddressHashSet,

massa-consensus/src/consensus_worker.rs

@@ -1202,7 +1202,7 @@ impl ConsensusWorker {
         self.block_db.get_operations(operation_ids)
     }
 
-    /// Manages received protocolevents.
+    /// Manages received protocol events.
     ///
     /// # Arguments
     /// * event: event type to process.

massa-consensus/src/tests/scenario_roll.rs

@@ -476,6 +476,7 @@ async fn test_roll() {
     .await;
 }
 
+#[ignore]
 #[tokio::test]
 #[serial]
 async fn test_roll_block_creation() {