Skip to content

Commit 20ca2f4

Browse files
3ktelasticsearchmachine
andauthored
Adding 'mode' and 'codec' fields to ES monitoring template (elastic#143673)
* Enhance monitoring template by adding 'mode' and 'codec' fields to monitoring mapping * Added changelog entry * Fixed tests * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
1 parent b0c54bc commit 20ca2f4

File tree

5 files changed

+33
-2
lines changed

5 files changed

+33
-2
lines changed

docs/changelog/143673.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
pr: 143673
2+
summary: Add mode and codec fields to Stack Monitoring index template
3+
area: Monitoring
4+
type: enhancement
5+
issues: []

x-pack/plugin/core/template-resources/src/main/resources/monitoring-es-mb.json

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2020,6 +2020,14 @@
20202020
"ignore_above": 1024,
20212021
"type": "keyword"
20222022
},
2023+
"mode": {
2024+
"ignore_above": 1024,
2025+
"type": "keyword"
2026+
},
2027+
"codec": {
2028+
"ignore_above": 1024,
2029+
"type": "keyword"
2030+
},
20232031
"recovery": {
20242032
"properties": {
20252033
"stop_time": {
@@ -3699,6 +3707,14 @@
36993707
"type": "alias",
37003708
"path": "elasticsearch.index.name"
37013709
},
3710+
"mode": {
3711+
"type": "alias",
3712+
"path": "elasticsearch.index.mode"
3713+
},
3714+
"codec": {
3715+
"type": "alias",
3716+
"path": "elasticsearch.index.codec"
3717+
},
37023718
"primaries": {
37033719
"properties": {
37043720
"docs": {

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/MonitoringTemplateRegistry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public class MonitoringTemplateRegistry extends IndexTemplateRegistry {
7777
* writes monitoring data in ECS format as of 8.0. These templates define the ECS schema as well as alias fields for the old monitoring
7878
* mappings that point to the corresponding ECS fields.
7979
*/
80-
public static final int STACK_MONITORING_REGISTRY_VERSION = 8_00_00_99 + 23;
80+
public static final int STACK_MONITORING_REGISTRY_VERSION = 8_00_00_99 + 24;
8181
private static final String STACK_MONITORING_REGISTRY_VERSION_VARIABLE = "xpack.stack.monitoring.template.release.version";
8282
private static final String STACK_TEMPLATE_VERSION = "8";
8383
private static final String STACK_TEMPLATE_VERSION_VARIABLE = "xpack.stack.monitoring.template.version";

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/collector/indices/IndexStatsMonitoringDoc.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
import org.elasticsearch.cluster.metadata.IndexMetadata;
1313
import org.elasticsearch.cluster.routing.IndexRoutingTable;
1414
import org.elasticsearch.core.Nullable;
15+
import org.elasticsearch.index.IndexSettings;
16+
import org.elasticsearch.index.engine.EngineConfig;
1517
import org.elasticsearch.xcontent.XContentBuilder;
1618
import org.elasticsearch.xpack.core.monitoring.MonitoredSystem;
1719
import org.elasticsearch.xpack.core.monitoring.exporter.MonitoringDoc;
@@ -70,6 +72,8 @@ protected void innerToXContent(XContentBuilder builder, Params params) throws IO
7072
builder.field("uuid", metadata.getIndexUUID());
7173
builder.field("created", metadata.getCreationDate());
7274
builder.field("status", health.getStatus().name().toLowerCase(Locale.ROOT));
75+
builder.field("mode", IndexSettings.MODE.get(metadata.getSettings()).getName());
76+
builder.field("codec", EngineConfig.INDEX_CODEC_SETTING.get(metadata.getSettings()));
7377

7478
builder.startObject("shards");
7579
{
@@ -123,6 +127,8 @@ protected void innerToXContent(XContentBuilder builder, Params params) throws IO
123127
"index_stats.uuid",
124128
"index_stats.created",
125129
"index_stats.status",
130+
"index_stats.mode",
131+
"index_stats.codec",
126132
"index_stats.shards.total",
127133
"index_stats.shards.primaries",
128134
"index_stats.shards.replicas",

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/collector/indices/IndexStatsMonitoringDocTests.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@
2121
import org.elasticsearch.common.xcontent.XContentHelper;
2222
import org.elasticsearch.core.Strings;
2323
import org.elasticsearch.index.Index;
24+
import org.elasticsearch.index.IndexSettings;
2425
import org.elasticsearch.index.cache.query.QueryCacheStats;
2526
import org.elasticsearch.index.cache.request.RequestCacheStats;
27+
import org.elasticsearch.index.engine.EngineConfig;
2628
import org.elasticsearch.index.engine.SegmentsStats;
2729
import org.elasticsearch.index.fielddata.FieldDataStats;
2830
import org.elasticsearch.index.refresh.RefreshStats;
@@ -348,7 +350,9 @@ private String indexStatsSummary() throws IOException {
348350
.field("index", index.getName())
349351
.field("uuid", index.getUUID())
350352
.field("created", metadata.getCreationDate())
351-
.field("status", indexHealth.getStatus().name().toLowerCase(Locale.ROOT));
353+
.field("status", indexHealth.getStatus().name().toLowerCase(Locale.ROOT))
354+
.field("mode", IndexSettings.MODE.get(metadata.getSettings()).getName())
355+
.field("codec", EngineConfig.INDEX_CODEC_SETTING.get(metadata.getSettings()));
352356
{
353357
builder.startObject("shards")
354358
.field("total", total)

0 commit comments

Comments
 (0)