fixing IndicesServiceTests

masseyke · masseyke · commit c8fc29e5d1cf · 2025-07-10T14:10:05.000-05:00
diff --git a/server/src/test/java/org/elasticsearch/indices/IndicesServiceTests.java b/server/src/test/java/org/elasticsearch/indices/IndicesServiceTests.java
@@ -619,8 +619,8 @@ public void testStatsByShardDoesNotDieFromExpectedExceptions() {
             }
         }
 
-        when(mockIndicesService.iterator()).thenReturn(Collections.singleton(indexService).iterator());
-        when(indexService.iterator()).thenReturn(shards.iterator());
+        when(mockIndicesService.iterator()).thenAnswer(invocation -> Collections.singleton(indexService).iterator());
+        when(indexService.iterator()).thenAnswer(unused -> shards.iterator());
         when(indexService.index()).thenReturn(index);
 
         // real one, which has a logger defined

Original file line number	Diff line number	Diff line change
`@@ -619,8 +619,8 @@ public void testStatsByShardDoesNotDieFromExpectedExceptions() {`
`619`	`619`	`}`
`620`	`620`	`}`
`621`	`621`
`622`		`- when(mockIndicesService.iterator()).thenReturn(Collections.singleton(indexService).iterator());`
`623`		`- when(indexService.iterator()).thenReturn(shards.iterator());`
	`622`	`+ when(mockIndicesService.iterator()).thenAnswer(invocation -> Collections.singleton(indexService).iterator());`
	`623`	`+ when(indexService.iterator()).thenAnswer(unused -> shards.iterator());`
`624`	`624`	`when(indexService.index()).thenReturn(index);`
`625`	`625`
`626`	`626`	`// real one, which has a logger defined`