Skip to content

Commit f37ac20

Browse files
alambxudong963
authored andcommitted
Make CI green
1 parent 375d2e6 commit f37ac20

File tree

6 files changed

+51
-12
lines changed

6 files changed

+51
-12
lines changed

.github/workflows/audit.yml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,25 +23,27 @@ concurrency:
2323

2424
on:
2525
push:
26+
branches:
27+
- main
2628
paths:
2729
- "**/Cargo.toml"
2830
- "**/Cargo.lock"
29-
branches:
30-
- main
3131

3232
pull_request:
3333
paths:
3434
- "**/Cargo.toml"
3535
- "**/Cargo.lock"
3636

37+
merge_group:
38+
3739
jobs:
3840
security_audit:
3941
runs-on: ubuntu-latest
4042
steps:
41-
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
43+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
4244
- name: Install cargo-audit
43-
run: cargo install cargo-audit
45+
uses: taiki-e/install-action@f535147c22906d77695e11cb199e764aa610a4fc # v2.62.46
46+
with:
47+
tool: cargo-audit
4448
- name: Run audit check
45-
# Ignored until https://github.com/apache/datafusion/issues/15571
46-
# ignored py03 warning until arrow 55 upgrade
47-
run: cargo audit --ignore RUSTSEC-2024-0370 --ignore RUSTSEC-2025-0020 --ignore RUSTSEC-2025-0047
49+
run: cargo audit --ignore RUSTSEC-2025-0111

.github/workflows/rust.yml

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,21 @@ jobs:
266266
runs-on: ubuntu-latest
267267
container:
268268
image: amd64/rust
269+
volumes:
270+
- /usr/local:/host/usr/local
269271
steps:
272+
- name: Remove unnecessary preinstalled software
273+
run: |
274+
echo "Disk space before cleanup:"
275+
df -h
276+
# remove tool cache: about 8.5GB (github has host /opt/hostedtoolcache mounted as /__t)
277+
rm -rf /__t/* || true
278+
# remove Haskell runtime: about 6.3GB (host /usr/local/.ghcup)
279+
rm -rf /host/usr/local/.ghcup || true
280+
# remove Android library: about 7.8GB (host /usr/local/lib/android)
281+
rm -rf /host/usr/local/lib/android || true
282+
echo "Disk space after cleanup:"
283+
df -h
270284
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
271285
with:
272286
submodules: true
@@ -347,6 +361,19 @@ jobs:
347361
with:
348362
save-if: ${{ github.ref_name == 'main' }}
349363
shared-key: "amd-ci-linux-test-example"
364+
- name: Remove unnecessary preinstalled software
365+
run: |
366+
echo "Disk space before cleanup:"
367+
df -h
368+
apt-get clean
369+
rm -rf /__t/CodeQL
370+
rm -rf /__t/PyPy
371+
rm -rf /__t/Java_Temurin-Hotspot_jdk
372+
rm -rf /__t/Python
373+
rm -rf /__t/go
374+
rm -rf /__t/Ruby
375+
echo "Disk space after cleanup:"
376+
df -h
350377
- name: Run examples
351378
run: |
352379
# test datafusion-sql examples
@@ -444,7 +471,7 @@ jobs:
444471
export RUST_MIN_STACK=20971520
445472
export TPCH_DATA=`realpath datafusion/sqllogictest/test_files/tpch/data`
446473
cargo test plan_q --package datafusion-benchmarks --profile ci --features=ci -- --test-threads=1
447-
INCLUDE_TPCH=true cargo test --features backtrace --profile ci --package datafusion-sqllogictest --test sqllogictests
474+
INCLUDE_TPCH=true cargo test --features backtrace,parquet_encryption --profile ci --package datafusion-sqllogictest --test sqllogictests
448475
- name: Verify Working Directory Clean
449476
run: git diff --exit-code
450477

Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ rpath = false
198198
strip = false # Retain debug info for flamegraphs
199199

200200
[profile.ci]
201+
debug = false
201202
inherits = "dev"
202203
incremental = false
203204

datafusion/datasource-parquet/src/opener.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ pub(super) struct ParquetOpener {
9898
/// Coerce INT96 timestamps to specific TimeUnit
9999
pub coerce_int96: Option<TimeUnit>,
100100
/// Optional parquet FileDecryptionProperties
101+
#[cfg(feature = "parquet_encryption")]
101102
pub file_decryption_properties: Option<Arc<FileDecryptionProperties>>,
102103
/// Rewrite expressions in the context of the file schema
103104
pub(crate) expr_adapter_factory: Option<Arc<dyn PhysicalExprAdapterFactory>>,
@@ -151,9 +152,11 @@ impl FileOpener for ParquetOpener {
151152
let mut predicate_file_schema = Arc::clone(&self.logical_file_schema);
152153

153154
let enable_page_index = self.enable_page_index;
155+
#[cfg(feature = "parquet_encryption")]
154156
let encryption_context = self.get_encryption_context();
155157

156158
Ok(Box::pin(async move {
159+
#[cfg(feature = "parquet_encryption")]
157160
let file_decryption_properties = encryption_context
158161
.get_file_decryption_properties(&file_location)
159162
.await?;
@@ -502,6 +505,7 @@ where
502505
}
503506

504507
#[derive(Default)]
508+
#[cfg_attr(not(feature = "parquet_encryption"), allow(dead_code))]
505509
struct EncryptionContext {
506510
#[cfg(feature = "parquet_encryption")]
507511
file_decryption_properties: Option<Arc<FileDecryptionProperties>>,
@@ -544,6 +548,7 @@ impl EncryptionContext {
544548
}
545549

546550
#[cfg(not(feature = "parquet_encryption"))]
551+
#[allow(dead_code)]
547552
impl EncryptionContext {
548553
async fn get_file_decryption_properties(
549554
&self,
@@ -563,6 +568,7 @@ impl ParquetOpener {
563568
}
564569

565570
#[cfg(not(feature = "parquet_encryption"))]
571+
#[allow(dead_code)]
566572
fn get_encryption_context(&self) -> EncryptionContext {
567573
EncryptionContext::default()
568574
}

datafusion/datasource-parquet/src/source.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ use datafusion_physical_plan::metrics::Count;
5252
use datafusion_physical_plan::metrics::ExecutionPlanMetricsSet;
5353
use datafusion_physical_plan::DisplayFormatType;
5454

55+
#[cfg(feature = "parquet_encryption")]
5556
use datafusion_common::encryption::map_config_decryption_to_decryption;
5657
#[cfg(feature = "parquet_encryption")]
5758
use datafusion_execution::parquet_encryption::EncryptionFactory;
@@ -541,6 +542,7 @@ impl FileSource for ParquetSource {
541542
Arc::new(DefaultParquetFileReaderFactory::new(object_store)) as _
542543
});
543544

545+
#[cfg(feature = "parquet_encryption")]
544546
let file_decryption_properties = self
545547
.table_parquet_options()
546548
.crypto
@@ -576,6 +578,7 @@ impl FileSource for ParquetSource {
576578
enable_row_group_stats_pruning: self.table_parquet_options.global.pruning,
577579
schema_adapter_factory,
578580
coerce_int96,
581+
#[cfg(feature = "parquet_encryption")]
579582
file_decryption_properties,
580583
expr_adapter_factory,
581584
#[cfg(feature = "parquet_encryption")]

datafusion/sqllogictest/test_files/encrypted_parquet.slt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ STORED AS PARQUET LOCATION 'test_files/scratch/encrypted_parquet/' OPTIONS (
2929
-- Encryption properties
3030
'format.crypto.file_encryption.encrypt_footer' 'true',
3131
'format.crypto.file_encryption.footer_key_as_hex' '30313233343536373839303132333435', -- b"0123456789012345"
32-
'format.crypto.file_encryption.column_key_as_hex::double_field' '31323334353637383930313233343530', -- b"1234567890123450"
33-
'format.crypto.file_encryption.column_key_as_hex::float_field' '31323334353637383930313233343531', -- b"1234567890123451"
32+
'format.crypto.file_encryption.column_key_as_hex::double_field' '31323334353637383930313233343530', -- b"1234567890123450"
33+
'format.crypto.file_encryption.column_key_as_hex::float_field' '31323334353637383930313233343531', -- b"1234567890123451"
3434
-- Decryption properties
35-
'format.crypto.file_decryption.footer_key_as_hex' '30313233343536373839303132333435', -- b"0123456789012345"
36-
'format.crypto.file_decryption.column_key_as_hex::double_field' '31323334353637383930313233343530', -- b"1234567890123450"
35+
'format.crypto.file_decryption.footer_key_as_hex' '30313233343536373839303132333435', -- b"0123456789012345"
36+
'format.crypto.file_decryption.column_key_as_hex::double_field' '31323334353637383930313233343530', -- b"1234567890123450"
3737
'format.crypto.file_decryption.column_key_as_hex::float_field' '31323334353637383930313233343531', -- b"1234567890123451"
3838
)
3939

0 commit comments

Comments
 (0)