vvis: Do not overflow portalfile buffer when command line arg length >= 1024

dimhotepus · mastercoms · commit e48ccb58782e · 2025-02-22T20:10:33.000-05:00
Closes ValveSoftware#749
diff --git a/src/utils/vvis/vvis.cpp b/src/utils/vvis/vvis.cpp
@@ -1167,7 +1167,7 @@ int RunVVis( int argc, char **argv )
 	}
 	else
 	{
-		sprintf ( portalfile, "%s%s", inbase, argv[i] );
+		V_sprintf_safe ( portalfile, "%s%s", inbase, argv[i] );
 		Q_StripExtension( portalfile, portalfile, sizeof( portalfile ) );
 	}
 	strcat (portalfile, ".prt");

Original file line number	Diff line number	Diff line change
`@@ -1167,7 +1167,7 @@ int RunVVis( int argc, char **argv )`
`1167`	`1167`	`}`
`1168`	`1168`	`else`
`1169`	`1169`	`{`
`1170`		`- sprintf ( portalfile, "%s%s", inbase, argv[i] );`
	`1170`	`+ V_sprintf_safe ( portalfile, "%s%s", inbase, argv[i] );`
`1171`	`1171`	`Q_StripExtension( portalfile, portalfile, sizeof( portalfile ) );`
`1172`	`1172`	`}`
`1173`	`1173`	`strcat (portalfile, ".prt");`