fix: tips being changed multiple times during map load

when stats are loaded, tips get updated, cycling to another tip
this causes an unwanted tip cycle where the first tip could be
shown for a very short time while the player is reading it
and moving to a new random one seemingly arbitrarily

this keeps the same tip on the loading screen, as intended

Author: mastercoms

src/game/client/tf/vgui/tf_statsummary.cpp

@@ -483,7 +483,7 @@ void CTFStatsSummaryPanel::SetStats( CUtlVector<ClassStats_t> &vecClassStats )
 	m_aClassStats = vecClassStats; 
 	if ( m_bControlsLoaded )
 	{
-		UpdateDialog();
+		UpdateDialog(false);
 	}
 }
 
@@ -846,7 +846,7 @@ void CTFStatsSummaryPanel::UpdateLeaderboard()
 //-----------------------------------------------------------------------------
 // Purpose: Updates the dialog
 //-----------------------------------------------------------------------------
-void CTFStatsSummaryPanel::UpdateDialog()
+void CTFStatsSummaryPanel::UpdateDialog(bool bUpdateTip)
 {
 	UpdateMainBackground();
 
@@ -921,8 +921,11 @@ void CTFStatsSummaryPanel::UpdateDialog()
 	UpdateBarCharts();
 	// fill out class details
 	UpdateClassDetails();
-	// update the tip
-	UpdateTip();
+	if (bUpdateTip)
+	{
+		// update the tip
+		UpdateTip();
+	}
 	// show or hide controls depending on if we're interactive or not
 	UpdateControls();		
 }

src/game/client/tf/vgui/tf_statsummary.h

@@ -64,7 +64,7 @@ class CTFStatsSummaryPanel : public vgui::EditablePanel, public CGameEventListen
 
 	void Reset();
 	void SetDefaultSelections();
-	void UpdateDialog();
+	void UpdateDialog(bool bUpdateTip = true);
 	void UpdateBarCharts();
 	void UpdateClassDetails( bool bIsMVM = false );
 	void UpdateTip();