perf: use static ConVarRefs during relatively hot functions

instead of doing a O(n) lookup per frame in some cases, we can just
init the ConVarRef once

hottest function in R_LoadSkys, other ones are just possible during runtime
or called relatively a lot compared to other non-static ConVarRefs

Author: mastercoms

src/common/ServerBrowser/blacklisted_server_manager.cpp

@@ -223,7 +223,7 @@ bool CBlacklistedServerManager::IsServerBlacklisted( uint32 serverIP, int server
 {
 	netadr_t netAdr( serverIP, serverPort );
 
-	ConVarRef sb_showblacklists( "sb_showblacklists" );
+	static ConVarRef sb_showblacklists( "sb_showblacklists" );
 
 	for ( int i = 0; i < m_Blacklist.Count(); i++ )
 	{

src/engine/gl_warp.cpp

@@ -165,7 +165,7 @@ void R_LoadSkys( void )
 
 	char requestedsky[ 128 ];
 
-	ConVarRef skyname( "sv_skyname" );
+	static ConVarRef skyname( "sv_skyname" );
 	if ( skyname.IsValid() )
 	{
 		Q_strncpy( requestedsky, skyname.GetString(), sizeof( requestedsky ) );

src/engine/matsys_interface.cpp

@@ -412,7 +412,7 @@ static void ReadMaterialSystemConfigFromRegistry( MaterialSystem_Config_t &confi
 	config.SetFlag( MATSYS_VIDCFG_FLAGS_WINDOWED, ReadVideoConfigInt( "ScreenWindowed", 0 ) != 0 );
 #if defined( USE_SDL ) && !defined( SWDS )
 	// Read the ScreenDisplayIndex and set sdl_displayindex if it's there.
-	ConVarRef conVar( "sdl_displayindex" );
+	static ConVarRef conVar( "sdl_displayindex" );
 	if ( conVar.IsValid() )
 	{
 		int displayIndex = 0;
@@ -531,7 +531,7 @@ static void WriteMaterialSystemConfigToRegistry( const MaterialSystem_Config_t &
 
 #if defined( USE_SDL ) && !defined( SWDS )
 	// Save sdl_displayindex out to ScreenDisplayIndex.
-	ConVarRef conVar( "sdl_displayindex" );
+	static ConVarRef conVar( "sdl_displayindex" );
 	if ( conVar.IsValid() && !UseVR() )
 	{
 		WriteVideoConfigInt( "ScreenDisplayIndex", conVar.GetInt() );
@@ -683,7 +683,7 @@ void OverrideMaterialSystemConfig( MaterialSystem_Config_t &config )
 {
 	// enable/disable flashlight support based on mod (user can also set this explicitly)
 	// FIXME: this is only here because dxsupport_override.cfg is currently broken
-	ConVarRef mat_supportflashlight( "mat_supportflashlight" );
+	static ConVarRef mat_supportflashlight( "mat_supportflashlight" );
 	if ( mat_supportflashlight.GetInt() == -1 )
 	{
 		const char * gameName = COM_GetModDirectory();

src/game/client/in_steamcontroller.cpp

@@ -69,8 +69,8 @@ void CInput::ApplySteamControllerCameraMove( QAngle& viewangles, CUserCmd *cmd,
 	//roll the view angles so roll is 0 (the HL2 assumed state) and mouse adjustments are relative to the screen.
 	//Assuming roll is unchanging, we want mouse left to translate to screen left at all times (same for right, up, and down)	
 
-	ConVarRef cl_pitchdown ( "cl_pitchdown" );
-	ConVarRef cl_pitchup ( "cl_pitchup" );
+	static ConVarRef cl_pitchdown ( "cl_pitchdown" );
+	static ConVarRef cl_pitchup ( "cl_pitchup" );
 
 	// Scale yaw and pitch inputs by sensitivity, and make sure they are within acceptable limits (important to avoid exploits, e.g. during Demoman charge we must restrict allowed yaw).
 	float yaw = CAM_CapYaw( sc_yaw_sensitivity.GetFloat() * vecPosition.x );

src/game/client/tf/tf_hud_notification_panel.cpp

@@ -140,7 +140,7 @@ void CHudNotificationPanel::MsgFunc_HudNotify( bf_read &msg )
 void CHudNotificationPanel::MsgFunc_HudNotifyCustom( bf_read &msg )
 {
 	// Ignore notifications in minmode
-	ConVarRef cl_hud_minmode( "cl_hud_minmode", true );
+	static ConVarRef cl_hud_minmode( "cl_hud_minmode", true );
 	if ( cl_hud_minmode.IsValid() && cl_hud_minmode.GetBool() )
 		return;
 

src/game/server/effects.cpp

@@ -451,7 +451,7 @@ void CGibShooter::Spawn( void )
 
 CGib *CGibShooter::CreateGib ( void )
 {
-	ConVarRef violence_hgibs( "violence_hgibs" );
+	static ConVarRef violence_hgibs( "violence_hgibs" );
 	if ( violence_hgibs.IsValid() && !violence_hgibs.GetInt() )
 		return NULL;
 

src/game/server/env_tonemap_controller.cpp

@@ -178,7 +178,7 @@ void CEnvTonemapController::InputSetBloomScaleRange( inputdata_t &inputdata )
 void CEnvTonemapController::InputSetTonemapRate( inputdata_t &inputdata )
 {
 	// TODO: There should be a better way to do this.
-	ConVarRef mat_hdr_manual_tonemap_rate( "mat_hdr_manual_tonemap_rate" );
+	static ConVarRef mat_hdr_manual_tonemap_rate( "mat_hdr_manual_tonemap_rate" );
 	if ( mat_hdr_manual_tonemap_rate.IsValid() )
 	{
 		float flTonemapRate = inputdata.value.Float();

src/game/server/func_break.cpp

@@ -1050,7 +1050,7 @@ void CBreakable::Die( void )
 		iCount = func_break_max_pieces.GetInt();
 	}
 
-	ConVarRef breakable_disable_gib_limit( "breakable_disable_gib_limit" );
+	static ConVarRef breakable_disable_gib_limit( "breakable_disable_gib_limit" );
 	if ( !breakable_disable_gib_limit.GetBool() && iCount )
 	{
 		if ( m_PerformanceMode == PM_NO_GIBS )

src/game/server/triggers.cpp

@@ -2243,7 +2243,7 @@ void CTriggerPush::Activate()
 {
 	// Fix problems with triggers pushing too hard under sv_alternateticks.
 	// This is somewhat hacky, but it's simple and we're really close to shipping.
-	ConVarRef sv_alternateticks( "sv_alternateticks" );
+	static ConVarRef sv_alternateticks( "sv_alternateticks" );
 	if ( ( m_flAlternateTicksFix != 0 ) && sv_alternateticks.GetBool() )
 	{
 		m_flPushSpeed = m_flSpeed * m_flAlternateTicksFix;

src/game/shared/achievementmgr.cpp

@@ -1095,7 +1095,7 @@ bool CAchievementMgr::CheckAchievementsEnabled()
 		return false;
 	}
 
-	ConVarRef tf_bot_offline_practice( "tf_bot_offline_practice" );
+	static ConVarRef tf_bot_offline_practice( "tf_bot_offline_practice" );
 	// no achievements for offline practice
 	if ( tf_bot_offline_practice.GetInt() != 0 )
 	{