perf: shared object find optimizations

when an econ item view goes looking for a
econ item, it looks through the CSharedObjectTypeCache
ideally, this would maintain a map instead of looking up
with O(n) search, but that's a more complicated and scary
change

instead, skip the amount of virtual GetTypeID calls since
SharedObject::BIsKeyEqual is only used in CSharedObjectTypeCache
so the equal types are guaranteed. on GC, BIsKeyEqual is used in
CSharedObjectTransaction as well, so we keep the old check for it.

also move to a static_cast for CEconItem to be explicit/efficient with casting

Author: mastercoms

src/game/shared/econ/econ_item.cpp

@@ -1509,7 +1509,7 @@ bool CEconItem::BAddDestroyToMessage( std::string *pBuffer ) const
 bool CEconItem::BIsKeyLess( const CSharedObject & soRHS ) const
 {
 	Assert( GetTypeID() == soRHS.GetTypeID() );
-	const CEconItem & soSchemaRHS = (const CEconItem &)soRHS;
+	const CEconItem & soSchemaRHS = static_cast<const CEconItem &>(soRHS);
 
 	return m_ulID < soSchemaRHS.m_ulID;
 }

src/gcsdk/sharedobject.cpp

@@ -113,8 +113,13 @@ const char *CSharedObject::PchClassUpdateNodeName( int nTypeID )
 bool CSharedObject::BIsKeyEqual( const CSharedObject & soRHS ) const
 {
 	// Make sure they are the same type.
+#ifdef GC
 	if ( GetTypeID() != soRHS.GetTypeID() )
 		return false;
+#else
+	// BIsKeyEqual is only used for objects of the same type within their CSharedObjectTypeCache.
+	Assert ( GetTypeID() == soRHS.GetTypeID() );
+#endif
 
 	return !BIsKeyLess( soRHS ) && !soRHS.BIsKeyLess( *this );
 }