fix: use m_nTickBase instead of usercmd sequence number for seed

Author: mastercoms

src/game/client/c_baseplayer.h

@@ -313,6 +313,7 @@ class C_BasePlayer : public C_BaseCombatCharacter, public CGameEventListener
 
 	float					GetTimeBase( void ) const;
 	float					GetFinalPredictedTime() const;
+	int		GetTickBase() const { return m_nTickBase; }
 
 	bool					IsInVGuiInputMode() const;
 	bool					IsInViewModelVGuiInputMode() const;
@@ -572,6 +573,8 @@ class C_BasePlayer : public C_BaseCombatCharacter, public CGameEventListener
 	friend class CHL2GameMovement;
 	friend class CDODGameMovement;
 	friend class CPortalGameMovement;
+
+	friend class CInput;
 
 	// Accessors for gamemovement
 	float GetStepSize( void ) const { return m_Local.m_flStepSize; }

src/game/client/in_main.cpp

@@ -1269,7 +1269,7 @@ void CInput::CreateMove ( int sequence_number, float input_sample_frametime, boo
 
 	m_flLastForwardMove = cmd->forwardmove;
 
-	cmd->random_seed = MD5_PseudoRandom( sequence_number ) & 0x7fffffff;
+	cmd->random_seed = MD5_PseudoRandom( C_BasePlayer::GetLocalPlayer()->m_nFinalPredictedTick ) & 0x7fffffff;
 
 	HLTVCamera()->CreateMove( cmd );
 #if defined( REPLAY_ENABLED )
@@ -1315,7 +1315,8 @@ void CInput::DecodeUserCmdFromBuffer( bf_read& buf, int sequence_number )
 	CUserCmd nullcmd;
 	CUserCmd *cmd = &m_pCommands[ sequence_number % MULTIPLAYER_BACKUP];
 
-	ReadUsercmd( &buf, cmd, &nullcmd );
+	// TODO: demos sync with time base?
+	ReadUsercmd( &buf, cmd, &nullcmd, nullptr );
 }
 
 void CInput::ValidateUserCmd( CUserCmd *usercmd, int sequence_number )

src/game/server/gameinterface.cpp

@@ -3122,7 +3122,7 @@ float CServerGameClients::ProcessUsercmds( edict_t *player, bf_read *buf, int nu
 	for ( i = totalcmds - 1; i >= 0; i-- )
 	{
 		to = &cmds[ i ];
-		ReadUsercmd( buf, to, from );
+		ReadUsercmd( buf, to, from, pPlayer );
 		from = to;
 	}
 

src/game/server/player.h

@@ -725,6 +725,7 @@ class CBasePlayer : public CBaseCombatCharacter
 	// Bot accessors...
 	void	SetTimeBase( float flTimeBase );
 	float	GetTimeBase() const;
+	int		GetTickBase() const { return m_nTickBase; }
 	void	SetLastUserCommand( const CUserCmd &cmd );
 	const CUserCmd *GetLastUserCommand( void );
 

src/game/shared/usercmd.cpp

@@ -196,7 +196,7 @@ void WriteUsercmd( bf_write *buf, const CUserCmd *to, const CUserCmd *from )
 //			*from - 
 // Output : static void ReadUsercmd
 //-----------------------------------------------------------------------------
-void ReadUsercmd( bf_read *buf, CUserCmd *move, CUserCmd *from )
+void ReadUsercmd( bf_read *buf, CUserCmd *move, CUserCmd *from, CBasePlayer* player )
 {
 	// Assume no change
 	*move = *from;
@@ -277,7 +277,7 @@ void ReadUsercmd( bf_read *buf, CUserCmd *move, CUserCmd *from )
 	}
 
 
-	move->random_seed = MD5_PseudoRandom( move->command_number ) & 0x7fffffff;
+	move->random_seed = MD5_PseudoRandom( player ? player->GetTickBase() : move->command_number ) & 0x7fffffff;
 
 	if ( buf->ReadOneBit() )
 	{

src/game/shared/usercmd.h

@@ -174,7 +174,7 @@ class CUserCmd
 
 };
 
-void ReadUsercmd( bf_read *buf, CUserCmd *move, CUserCmd *from );
+void ReadUsercmd( bf_read *buf, CUserCmd *move, CUserCmd *from, CBasePlayer *player );
 void WriteUsercmd( bf_write *buf, const CUserCmd *to, const CUserCmd *from );
 
 #endif // USERCMD_H