Fix colors for Windows!

Author: masterking32

internal/logger/color_support_unix.go

@@ -0,0 +1,22 @@
+//go:build !windows
+
+package logger
+
+import (
+	"io"
+	"os"
+)
+
+func detectColorSupport(w io.Writer) bool {
+	f, ok := w.(*os.File)
+	if !ok {
+		return false
+	}
+
+	info, err := f.Stat()
+	if err != nil {
+		return false
+	}
+
+	return (info.Mode() & os.ModeCharDevice) != 0
+}

internal/logger/color_support_windows.go

@@ -0,0 +1,31 @@
+//go:build windows
+
+package logger
+
+import (
+	"io"
+	"os"
+
+	"golang.org/x/sys/windows"
+)
+
+const enableVirtualTerminalProcessing = 0x0004
+
+func detectColorSupport(w io.Writer) bool {
+	f, ok := w.(*os.File)
+	if !ok {
+		return false
+	}
+
+	handle := windows.Handle(f.Fd())
+	var mode uint32
+	if err := windows.GetConsoleMode(handle, &mode); err != nil {
+		return false
+	}
+
+	if mode&enableVirtualTerminalProcessing != 0 {
+		return true
+	}
+
+	return windows.SetConsoleMode(handle, mode|enableVirtualTerminalProcessing) == nil
+}

internal/logger/logger.go

@@ -215,11 +215,7 @@ func shouldUseColor() bool {
 	if strings.TrimSpace(os.Getenv("FORCE_COLOR")) != "" {
 		return true
 	}
-	info, err := os.Stdout.Stat()
-	if err != nil {
-		return false
-	}
-	return (info.Mode() & os.ModeCharDevice) != 0
+	return detectColorSupport(os.Stdout)
 }
 
 func renderColorTags(text string) string {

internal/logger/logger_test.go

@@ -9,6 +9,7 @@ package logger
 
 import (
 	"bytes"
+	"os"
 	"strings"
 	"testing"
 )
@@ -76,3 +77,19 @@ func TestLoggerSuppressesBelowLevel(t *testing.T) {
 		t.Fatal("warn message should be logged at WARN level")
 	}
 }
+
+func TestShouldUseColorHonorsNoColor(t *testing.T) {
+	oldNoColor := os.Getenv("NO_COLOR")
+	oldForceColor := os.Getenv("FORCE_COLOR")
+	t.Cleanup(func() {
+		_ = os.Setenv("NO_COLOR", oldNoColor)
+		_ = os.Setenv("FORCE_COLOR", oldForceColor)
+	})
+
+	_ = os.Setenv("FORCE_COLOR", "1")
+	_ = os.Setenv("NO_COLOR", "1")
+
+	if shouldUseColor() {
+		t.Fatal("NO_COLOR should disable colors even when FORCE_COLOR is set")
+	}
+}