Skip to content

docs: update version number in example on readme #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 26, 2025
Merged

docs: update version number in example on readme #59

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71eec10
wip: test turninging off tags
westonplatter Sep 25, 2025
8cb2c66
undo
westonplatter Sep 25, 2025
5834906
reverse
westonplatter Sep 26, 2025
c2dde08
docs: update version number in readme
westonplatter Sep 26, 2025
c0a83ca
fix: bring this back
westonplatter Sep 26, 2025
342adac
fix: encourage user to find latest version
westonplatter Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@ Big shout out to the following projects which this project uses/depends on/menti

```hcl
module "ssm_agent" {
source = "masterpointio/ssm-agent/aws"
version = "0.15.1"
stage = var.stage
namespace = var.namespace
source = "masterpointio/ssm-agent/aws"
version = "1.8.0"
Copy link
Contributor

@oycyc oycyc Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes sense to put something like "x.x.x" so it suggests to the consumer to take the latest version and pin it. CloudPosse does this (https://github.com/cloudposse/terraform-aws-s3-bucket) and we do as well in the Tailscale module (https://github.com/masterpointio/terraform-aws-tailscale/)

Copy link
Member Author

@westonplatter westonplatter Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think x.x.x is a better solution to encourage/force users to look up the version numbers.


namespace = var.namespace
stage = var.stage

vpc_id = module.vpc.vpc_id
subnet_ids = module.subnets.private_subnet_ids
}
Expand All @@ -50,8 +52,9 @@ module "vpc" {
}

module "subnets" {
source = "cloudposse/dynamic-subnets/aws"
version = "2.3.0"
source = "cloudposse/dynamic-subnets/aws"
version = "2.3.0"

namespace = var.namespace
stage = var.stage

Expand Down