Allow to disable registration

As a default registration is open, which will not suit (most)
public installations.

This is a first step towards better handling of server
registration, allowing for registration to be disabled altogether.

Future work will be to allow for a more nuanced approach, maybe
using invite codes or similar methods.

Author: oneiros

debug_fasp/app/views/layouts/application.html.erb

@@ -34,7 +34,9 @@
           <% if signed_in? %>
             <%= nav_link_to t('.sign_out'), fasp_base.session_path, data: {turbo_method: :delete} %>
           <% else %>
-            <%= nav_link_to t(".sign_up"), fasp_base.new_registration_path %>
+            <% if FaspBase.registration_enabled? %>
+              <%= nav_link_to t(".sign_up"), fasp_base.new_registration_path %>
+            <% end %>
             <%= nav_link_to t(".sign_in"), fasp_base.new_session_path %>
           <% end %>
         </div>

debug_fasp/config/initializers/fasp_base.rb

@@ -9,6 +9,7 @@
   f.privacy_policy_language = ENV["PRIVACY_POLICY_LANGUAGE"]
   f.contact_email = ENV["CONTACT_EMAIL"]
   f.fediverse_account = ENV["FEDIVERSE_ACCOUNT"]
+  f.registration_enabled = ENV["DISABLE_SERVER_REGISTRATION"].present? ? false : true
 end
 
 Rails.application.config.to_prepare do

fasp_base/app/controllers/fasp_base/registrations_controller.rb

@@ -2,6 +2,8 @@ module FaspBase
   class RegistrationsController < ApplicationController
     skip_authentication
 
+    before_action :registration_allowed
+
     def new
       @registration = Registration.new
     end
@@ -31,5 +33,9 @@ def registration_params
       params.require(:registration)
         .permit(:email, :base_url, :password, :password_confirmation)
     end
+
+    def registration_allowed
+      head :not_found unless FaspBase.registration_enabled?
+    end
   end
 end

fasp_base/lib/fasp_base.rb

@@ -13,6 +13,7 @@ class Error < ::StandardError ; end
   mattr_accessor :capabilities, default: []
   mattr_accessor :contact_email
   mattr_accessor :fediverse_account
+  mattr_accessor :registration_enabled, default: true
 
   def self.base_url
     protocol = Rails.env.production? ? "https" : "http"
@@ -24,4 +25,6 @@ def self.supports?(capability, version:)
       supported_capability[:id] == capability && supported_capability[:version].start_with?(version.to_s)
     end
   end
+
+  def self.registration_enabled? = registration_enabled
 end

fasp_base/lib/generators/fasp_base/install/templates/initializers/fasp_base.rb

@@ -13,6 +13,9 @@
   # f.privacy_policy_language = ENV["PRIVACY_POLICY_LANGUAGE"]
   # f.contact_email = ENV["CONTACT_EMAIL"]
   # f.fediverse_account = ENV["FEDIVERSE_ACCOUNT"]
+
+  # Disable open registration
+  # f.registration_enabled = false
 end
 
 # If you plan to patch classes from the `fasp_base` engine

fasp_base/lib/generators/fasp_base/install/templates/layouts/application.html.erb

@@ -33,7 +33,9 @@
           <% if signed_in? %>
             <%= nav_link_to t('.sign_out'), fasp_base.session_path, data: {turbo_method: :delete} %>
           <% else %>
-            <%= nav_link_to t(".sign_up"), fasp_base.new_registration_path %>
+            <% if FaspBase.registration_enabled? %>
+              <%= nav_link_to t(".sign_up"), fasp_base.new_registration_path %>
+            <% end %>
             <%= nav_link_to t(".sign_in"), fasp_base.new_session_path %>
           <% end %>
         </div>

fasp_base/test/integration/registration_test.rb

@@ -7,6 +7,26 @@ class RegistrationTest < ActionDispatch::IntegrationTest
     stub_fasp_registration
   end
 
+  test "disabled registration" do
+    FaspBase.registration_enabled = false
+    get fasp_base.new_registration_path
+
+    assert_response :not_found
+
+    post fasp_base.registration_path, params: {
+      registration: {
+        email: "user@example.com",
+        password: "super_secret",
+        password_confirmation: "super_secret",
+        base_url: "https://fedi.example.com/fasp"
+      }
+    }
+
+    assert_response :not_found
+
+    FaspBase.registration_enabled = true
+  end
+
   test "requesting the registration form" do
     get fasp_base.new_registration_path