Skip to content

Commit 932ece3

Browse files
committed
Make quote settings explanation match settings structure
1 parent 4bd0b52 commit 932ece3

File tree

5 files changed

+12
-5
lines changed

5 files changed

+12
-5
lines changed

mastodon/src/main/java/org/joinmastodon/android/fragments/ComposeFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1058,7 +1058,7 @@ private void toggleSpoiler(){
10581058
private void onVisibilityClick(View v){
10591059
if(instance.supportsQuotePostAuthoring()){
10601060
ComposerVisibilitySheet sheet=new ComposerVisibilitySheet(getActivity(), statusVisibility, statusQuotePolicy,
1061-
true, quotedStatus==null ? StatusPrivacy.PUBLIC : quotedStatus.visibility, (s, visibility, policy)->{
1061+
true, quotedStatus==null ? StatusPrivacy.PUBLIC : quotedStatus.visibility, accountID, (s, visibility, policy)->{
10621062
if(statusVisibility!=visibility || statusQuotePolicy!=policy){
10631063
statusVisibility=visibility;
10641064
statusQuotePolicy=policy;

mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/HeaderStatusDisplayItem.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ public void onError(ErrorResponse error){
249249
.exec(item.accountID);
250250
}else if(id==R.id.change_quote_policy){
251251
ComposerVisibilitySheet sheet=new ComposerVisibilitySheet(activity, item.status.visibility, item.status.quoteApproval.toQuotePolicy(),
252-
false, StatusPrivacy.PUBLIC, (s, visibility, policy)->{
252+
false, StatusPrivacy.PUBLIC, item.accountID, (s, visibility, policy)->{
253253
new SetStatusInteractionPolicies(item.status.id, policy)
254254
.setCallback(new Callback<>(){
255255
@Override

mastodon/src/main/java/org/joinmastodon/android/ui/sheets/ComposerVisibilitySheet.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@
1212
import android.widget.ArrayAdapter;
1313
import android.widget.Button;
1414
import android.widget.Spinner;
15+
import android.widget.TextView;
1516

1617
import org.joinmastodon.android.R;
18+
import org.joinmastodon.android.api.session.AccountSessionManager;
1719
import org.joinmastodon.android.model.StatusPrivacy;
1820
import org.joinmastodon.android.model.StatusQuotePolicy;
1921
import org.joinmastodon.android.model.viewmodel.ListItem;
@@ -38,13 +40,16 @@ public class ComposerVisibilitySheet extends BottomSheet{
3840
private StatusQuotePolicy userSelectedPolicy;
3941
private final Listener listener;
4042

41-
public ComposerVisibilitySheet(@NonNull Context context, StatusPrivacy defaultVisibility, StatusQuotePolicy defaultPolicy, boolean canChangeVisibility, StatusPrivacy maxVisibility, Listener listener){
43+
public ComposerVisibilitySheet(@NonNull Context context, StatusPrivacy defaultVisibility, StatusQuotePolicy defaultPolicy, boolean canChangeVisibility, StatusPrivacy maxVisibility, String accountID, Listener listener){
4244
super(context);
4345
View content=context.getSystemService(LayoutInflater.class).inflate(R.layout.sheet_compose_visibility, null);
4446
setContentView(content);
4547
setNavigationBarBackground(new ColorDrawable(UiUtils.alphaBlendColors(UiUtils.getThemeColor(context, R.attr.colorM3Surface),
4648
UiUtils.getThemeColor(context, R.attr.colorM3Primary), 0.05f)), !UiUtils.isDarkTheme());
4749

50+
TextView subtitle=findViewById(R.id.subtitle);
51+
subtitle.setText(context.getString(R.string.compose_visibility_explanation, AccountSessionManager.get(accountID).getFullUsername()));
52+
4853
Button cancelBtn=findViewById(R.id.cancel);
4954
Button saveBtn=findViewById(R.id.save);
5055
cancelBtn.setOnClickListener(v->dismiss());

mastodon/src/main/res/layout/sheet_compose_visibility.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,12 @@
2727
android:text="@string/compose_visibility_title"/>
2828

2929
<TextView
30+
android:id="@+id/subtitle"
3031
android:layout_width="match_parent"
3132
android:layout_height="wrap_content"
3233
android:layout_marginTop="16dp"
3334
android:textAppearance="@style/m3_body_medium"
34-
android:text="@string/compose_visibility_explanation"/>
35+
tools:text="@string/compose_visibility_explanation"/>
3536

3637
<org.joinmastodon.android.ui.views.FloatingHintEditTextLayout
3738
android:id="@+id/visibility_spinner_wrap"

mastodon/src/main/res/values/strings.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,8 @@
887887
<string name="compose_visibility_unlisted_limited">Quiet public, quotes limited</string>
888888
<string name="compose_visibility_unlisted_disabled">Quiet public, quotes disabled</string>
889889
<string name="compose_visibility_title">Visibility and interaction</string>
890-
<string name="compose_visibility_explanation"><![CDATA[Control who can interact with this post. Global settings can be found under Preferences > Other.]]></string>
890+
<!-- %s is current user's full username, e.g. @example@mastodon.social -->
891+
<string name="compose_visibility_explanation"><![CDATA[Control who can interact with this post. Global settings can be found under Settings > %s > Posting defaults.]]></string>
891892
<string name="compose_visibility">Visibility</string>
892893
<string name="compose_quote_policy">Who can quote</string>
893894
<string name="quote_policy_public">Anyone</string>

0 commit comments

Comments
 (0)