Skip to content

Commit bd5a783

Browse files
committed
Move predict_top_k_ms2deepscore as well
1 parent 25508a6 commit bd5a783

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

ms2query/ms2query_development/predict_top_k_ms2deepscore.py renamed to ms2query/ms2query_development/reference_methods/predict_top_k_ms2deepscore.py

File renamed without changes.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
All files here are not important to core functionality and in fact not used for running the final version of MS2Query. However MS2DeepSCoresForTopInChikeys is core to the benchmarking in the notebooks. predict_best_possible_match and EvaluateExactMatchSearch are not yet used for the benchmarking, but both should still be done, so this could be used for that.
1+
All files here are not important to core functionality and in fact not used for running the final version of MS2Query. However MS2DeepSCoresForTopInChikeys and predict_top-k_ms2deepscore are core to the benchmarking and experimenting in the notebooks. predict_best_possible_match and EvaluateExactMatchSearch are not yet used for the benchmarking, but both should still be done, so this could be used for that.

ms2query/notebooks/develop_and_compare_ms2query_2.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@
488488
"metadata": {},
489489
"outputs": [],
490490
"source": [
491-
"from ms2query.ms2query_development.predict_top_k_ms2deepscore import select_inchikeys_with_highest_ms2deepscore\n",
491+
"from ms2query.ms2query_development.reference_methods.predict_top_k_ms2deepscore import select_inchikeys_with_highest_ms2deepscore\n",
492492
"\n",
493493
"inchikeys_with_highest_ms2deepscores = select_inchikeys_with_highest_ms2deepscore(\n",
494494
" pos_val_spectra, pos_train_spectra, nr_of_inchikeys_to_select=1, batch_size=1000,)\n"
@@ -2632,7 +2632,7 @@
26322632
"source": [
26332633
"from ms2query.ms2query_development.Fingerprints import Fingerprints\n",
26342634
"from ms2query.ms2query_development.TopKTanimotoScores import TopKTanimotoScores\n",
2635-
"from ms2query.ms2query_development.predict_top_k_ms2deepscore import select_inchikeys_with_highest_ms2deepscore\n",
2635+
"from ms2query.ms2query_development.reference_methods.predict_top_k_ms2deepscore import select_inchikeys_with_highest_ms2deepscore\n",
26362636
"from ms2query.ms2query_development.reference_methods.MS2DeepScoresForTopInChikeys import calculate_MS2DeepScoresForTopKInChikeys\n",
26372637
"\n",
26382638
"neg_val_fingerprints = Fingerprints.from_spectrum_set(neg_val_spectra, \"daylight\", 4096)\n",
@@ -2714,7 +2714,7 @@
27142714
"metadata": {},
27152715
"outputs": [],
27162716
"source": [
2717-
"from ms2query.ms2query_development.predict_top_k_ms2deepscore import predict_top_k_ms2deepscores\n",
2717+
"from ms2query.ms2query_development.reference_methods.predict_top_k_ms2deepscore import predict_top_k_ms2deepscores\n",
27182718
"\n",
27192719
"indexes, ms2deepscores = predict_top_k_ms2deepscores(neg_train_spectra.embeddings, neg_val_spectra.embeddings)\n",
27202720
"neg_predicted_inchikeys_ms2deepscore = [neg_train_spectra.spectra[int(index)].get(\"inchikey\")[:14] for index in indexes]\n",

tests/test_ms2query_development/test_MS2DeepScoresForTopInChikeys.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from ms2query.ms2query_development.AnnotatedSpectrumSet import AnnotatedSpectrumSet
2-
from ms2query.ms2query_development.MS2DeepScoresForTopInChikeys import (
2+
from ms2query.ms2query_development.reference_methods.MS2DeepScoresForTopInChikeys import (
33
calculate_MS2DeepScoresForTopKInChikeys_from_spectra,
44
)
55
from tests.helper_functions import create_test_spectra, ms2deepscore_model

0 commit comments

Comments
 (0)