Fix shellcheck for shift in parse_commandline

kstrafe · kstrafe · commit 5941f5667861 · 2025-04-27T17:45:05.000-04:00
diff --git a/bin/argbash b/bin/argbash
@@ -234,6 +234,7 @@ parse_commandline()
 				_positionals_count=$((_positionals_count + 1))
 				;;
 		esac
+		# shellcheck disable=SC2317
 		shift
 	done
 }
diff --git a/resources/examples/simple-parsing.sh b/resources/examples/simple-parsing.sh
@@ -95,6 +95,7 @@ parse_commandline()
         _positionals_count=$((_positionals_count + 1))
         ;;
     esac
+    # shellcheck disable=SC2317
     shift
   done
 }
diff --git a/resources/examples/simple-wrapper.sh b/resources/examples/simple-wrapper.sh
@@ -104,6 +104,7 @@ parse_commandline()
         _positionals_count=$((_positionals_count + 1))
         ;;
     esac
+    # shellcheck disable=SC2317
     shift
   done
 }
diff --git a/src/function_generators.m4 b/src/function_generators.m4
@@ -175,6 +175,7 @@ m4_define([_MAKE_ARGV_PARSING_FUNCTION], [MAKE_FUNCTION(
 			[_EVAL_OPTIONALS_AND_POSITIONALS],
 			[_STORE_CURRENT_ARG_AS_POSITIONAL])],
 		[_JOIN_INDENTED(1,
+			[_INDENT_()[# shellcheck disable=SC2317]],
 			[_INDENT_()[shift]],
 			[done])],
 	)],

Original file line number	Diff line number	Diff line change
`@@ -234,6 +234,7 @@ parse_commandline()`
`234`	`234`	`_positionals_count=$((_positionals_count + 1))`
`235`	`235`	`;;`
`236`	`236`	`esac`
	`237`	`+ # shellcheck disable=SC2317`
`237`	`238`	`shift`
`238`	`239`	`done`
`239`	`240`	`}`
Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ parse_commandline()`
`95`	`95`	`_positionals_count=$((_positionals_count + 1))`
`96`	`96`	`;;`
`97`	`97`	`esac`
	`98`	`+ # shellcheck disable=SC2317`
`98`	`99`	`shift`
`99`	`100`	`done`
`100`	`101`	`}`
Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,7 @@ parse_commandline()`
`104`	`104`	`_positionals_count=$((_positionals_count + 1))`
`105`	`105`	`;;`
`106`	`106`	`esac`
	`107`	`+ # shellcheck disable=SC2317`
`107`	`108`	`shift`
`108`	`109`	`done`
`109`	`110`	`}`