refactor(appstore): move http to be a suspending function

Author: sockeye-d

appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/ApiClientImpl.kt

@@ -11,13 +11,17 @@ import com.matejdro.micropebble.common.util.joinUrls
 import dev.zacsweers.metro.AppScope
 import dev.zacsweers.metro.ContributesBinding
 import dev.zacsweers.metro.Inject
+import dispatch.core.withIO
 import io.ktor.client.HttpClient
 import io.ktor.client.call.body
+import io.ktor.client.engine.ProxyBuilder.http
 import io.ktor.client.plugins.contentnegotiation.ContentNegotiation
 import io.ktor.client.request.get
+import io.ktor.http.parameters
 import io.ktor.serialization.kotlinx.json.json
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.runBlocking
+import kotlinx.coroutines.withContext
 import kotlinx.serialization.json.Json
 
 @Inject
@@ -28,35 +32,35 @@ class ApiClientImpl : ApiClient {
       ignoreUnknownKeys = true
    }
 
-   private val http by lazy {
-      runBlocking(Dispatchers.IO) {
-         HttpClient {
-            install(ContentNegotiation) {
-               json(json)
-            }
+   private var client: HttpClient? = null
+
+   private suspend fun getHttp() = client ?: withContext(Dispatchers.IO) {
+      HttpClient {
+         install(ContentNegotiation) {
+            json(json)
          }
       }
-   }
+   }.also { client = it }
 
    override suspend fun fetchAppListing(updateSource: AppstoreSource, installSource: AppInstallSource) = runCatching {
-      http.get(updateSource.url.joinUrls("/v1/apps/id/${installSource.storeId}")).body<ApplicationList>().data.first()
+      getHttp().get(updateSource.url.joinUrls("/v1/apps/id/${installSource.storeId}")).body<ApplicationList>().data.first()
    }.getOrNull()
 
    override suspend fun fetchAppListing(updateSource: AppstoreSource, appstoreId: String) =
-      http.get(updateSource.url.joinUrls("/v1/apps/id/$appstoreId")).body<AppstoreCollectionPage>().apps.first()
+      getHttp().get(updateSource.url.joinUrls("/v1/apps/id/$appstoreId")).body<AppstoreCollectionPage>().apps.first()
 
    override suspend fun fetchHomePage(
       source: AppstoreSource,
       type: ApplicationType,
       platformFilter: String?,
-   ) = http.get(source.url.joinUrls(type.apiEndpoint)) {
+   ) = getHttp().get(source.url.joinUrls(type.apiEndpoint)) {
       url {
          platformFilter?.let { parameters["hardware"] = it }
       }
    }.body<AppstoreHomePage>()
 
    override suspend fun fetchCollection(platformFilter: String?, endpoint: String, offset: Int, limit: Int) =
-      http.get(endpoint) {
+      getHttp().get(endpoint) {
          url {
             platformFilter?.let { parameters["hardware"] = it }
             parameters["offset"] = offset.toString()