Audit and cleanup TODOs and lints; update dep versions

- BottomNavigationDrawerFragment changed to use motion.xml duration for sandwich toggle duration.
- Organized all imports
- Resolved/removed all TODOs
- Lint checks resolved where possible

Change-Id: I1155cdb31704c11c09c5c006451f104a4fc6d9de

Author: hunterstich

app/build.gradle

@@ -52,12 +52,12 @@ dependencies {
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
 
     // AndroidX
-    implementation 'androidx.appcompat:appcompat:1.1.0-beta01'
-    implementation 'androidx.constraintlayout:constraintlayout:2.0.0-beta1'
+    implementation 'androidx.appcompat:appcompat:1.1.0'
+    implementation 'androidx.constraintlayout:constraintlayout:2.0.0-beta2'
     implementation 'androidx.legacy:legacy-support-v4:1.0.0'
-    implementation 'androidx.recyclerview:recyclerview:1.1.0-alpha06'
-    implementation 'androidx.core:core-ktx:1.0.2'
-    implementation 'androidx.lifecycle:lifecycle-livedata-core-ktx:2.2.0-alpha03'
+    implementation 'androidx.recyclerview:recyclerview:1.1.0-beta05'
+    implementation 'androidx.core:core-ktx:1.1.0'
+    implementation 'androidx.lifecycle:lifecycle-livedata-core-ktx:2.2.0-beta01'
     implementation "androidx.navigation:navigation-fragment-ktx:$navigation_version"
     implementation "androidx.navigation:navigation-ui-ktx:$navigation_version"
 
@@ -71,5 +71,4 @@ dependencies {
     testImplementation 'junit:junit:4.12'
     androidTestImplementation 'androidx.test:runner:1.2.0'
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
-
 }

app/src/main/AndroidManifest.xml

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     package="com.materialstudies.reply">
 
     <application
@@ -8,7 +9,8 @@
         android:label="@string/app_name"
         android:roundIcon="@mipmap/ic_launcher_round"
         android:supportsRtl="true"
-        android:theme="@style/Theme.Reply.DayNight">
+        android:theme="@style/Theme.Reply.DayNight"
+        tools:ignore="AllowBackup">
         <activity android:name=".ui.MainActivity">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />

app/src/main/java/com/materialstudies/reply/data/AccountStore.kt

@@ -156,7 +156,7 @@ object AccountStore {
     fun getAllUserAccounts() = allUserAccounts
 
     /**
-     * Whether or not the given [accountId] is an account owned by the current user.
+     * Whether or not the given [Account.id] uid is an account owned by the current user.
      */
     fun isUserAccount(uid: Long): Boolean = allUserAccounts.any { it.uid == uid }
 

app/src/main/java/com/materialstudies/reply/data/Email.kt

@@ -31,7 +31,6 @@ data class Email(
     var isImportant: Boolean = false,
     var isStarred: Boolean = false
 ) {
-    //TODO(hunterstich) Update to use real Dates.
     val senderPreview: String = "${sender.fullName} - 4 hrs ago"
     val hasBody: Boolean = body.isNotBlank()
     val hasAttachments: Boolean = attachments.isNotEmpty()

app/src/main/java/com/materialstudies/reply/data/EmailStore.kt

@@ -97,8 +97,6 @@ object EmailStore {
                 I've been doing a bit of research and have come across a few paces in Northern Brazil that I think we should check out. One, the north has some of the most predictable wind on the planet. I'd love to get out on the ocean and kitesurf for a couple of days if we're going to be anywhere near or around Taiba. I hear it's beautiful there and if you're up for it, I'd love to go. Other than that, I haven't spent too much time looking into places along our road trip route. I'm assuming we can find places to stay and things to do as we drive and find places we think look interesting. But... I know you're more of a planner, so if you have ideas or places in mind, lets jot some ideas down!
 
                 Maybe we can jump on the phone later today if you have a second.
-
-                I've been doing a bit of research and have come across a few paces in Northern Brazil that I think we should check out. One, the north has some of the most predictable wind on the planet. I'd love to get out on the ocean and kitesurf for a couple of days if we're going to be anywhere near or around Taiba. I hear it's beautiful there and if you're up for it, I'd love to go. Other than that, I haven't spent too much time looking into places along our road trip route. I'm assuming we can find places to stay and things to do as we drive and find places we think look interesting. But... I know you're more of a planner, so if you have ideas or places in mind, lets jot some ideas down!
             """.trimIndent(),
             isStarred = true
         ),
@@ -195,6 +193,5 @@ object EmailStore {
         "Mortgage",
         "Grocery coupons"
     )
-
 }
 

app/src/main/java/com/materialstudies/reply/ui/common/EmailAttachmentAdapter.kt

@@ -57,5 +57,4 @@ abstract class EmailAttachmentAdapter : RecyclerView.Adapter<EmailAttachmentView
      * of [EmailAttachment].
      */
     abstract fun getLayoutIdForPosition(position: Int): Int
-
 }

app/src/main/java/com/materialstudies/reply/ui/email/EmailAttachmentGridAdapter.kt

@@ -41,7 +41,7 @@ class EmailAttachmentGridAdapter(
             val list = mutableListOf<Int>()
 
             var rowSpansOccupied = 0
-            (0..count).forEach {
+            repeat(count) {
                 val size = Random.nextInt(1, spans + 1 - rowSpansOccupied)
                 rowSpansOccupied += size
                 if (rowSpansOccupied >= 3) rowSpansOccupied = 0
@@ -59,5 +59,4 @@ class EmailAttachmentGridAdapter(
 
     override fun getLayoutIdForPosition(position: Int): Int =
         R.layout.email_attachment_grid_item_layout
-
 }

app/src/main/java/com/materialstudies/reply/ui/home/EmailSwipeActionDrawable.kt

@@ -29,11 +29,12 @@ import androidx.annotation.ColorInt
 import androidx.appcompat.content.res.AppCompatResources
 import androidx.interpolator.view.animation.FastOutSlowInInterpolator
 import com.materialstudies.reply.R
-import com.materialstudies.reply.util.themeColor
 import com.materialstudies.reply.util.lerp
 import com.materialstudies.reply.util.lerpArgb
+import com.materialstudies.reply.util.themeColor
 import kotlin.math.abs
 import kotlin.math.hypot
+import kotlin.math.sin
 
 /**
  * A [Drawable] which handles drawing the background behind an email item preview and responds to
@@ -85,7 +86,7 @@ class EmailSwipeActionDrawable(context: Context) : Drawable() {
         update()
     }
 
-    fun update() {
+    private fun update() {
         circle.set(
             bounds.left.toFloat(),
             bounds.top.toFloat(),
@@ -141,8 +142,7 @@ class EmailSwipeActionDrawable(context: Context) : Drawable() {
         )
         // Take the sin of our ranged progress * our maxScaleAddition as what we should
         // increase the icon's scale by.
-        val additive = (Math.sin(range.toDouble()) * iconMaxScaleAddition)
-            .coerceIn(0.0, 1.0)
+        val additive = (sin(range.toDouble()) * iconMaxScaleAddition).coerceIn(0.0, 1.0)
         val scaleFactor = 1 + additive
         icon.setBounds(
             (cx - (iconIntrinsicWidth / 2F) * scaleFactor).toInt(),
@@ -169,5 +169,4 @@ class EmailSwipeActionDrawable(context: Context) : Drawable() {
     override fun setColorFilter(filter: ColorFilter?) {
         circlePaint.colorFilter = filter
     }
-
 }

app/src/main/java/com/materialstudies/reply/ui/home/EmailViewHolder.kt

@@ -22,8 +22,8 @@ import com.materialstudies.reply.R
 import com.materialstudies.reply.data.Email
 import com.materialstudies.reply.databinding.EmailItemLayoutBinding
 import com.materialstudies.reply.ui.common.EmailAttachmentAdapter
-import com.materialstudies.reply.util.themeStyle
 import com.materialstudies.reply.util.setTextAppearanceCompat
+import com.materialstudies.reply.util.themeStyle
 import kotlin.math.abs
 
 class EmailViewHolder(

app/src/main/java/com/materialstudies/reply/ui/home/HomeFragment.kt

@@ -91,5 +91,4 @@ class HomeFragment : Fragment(), EmailAdapter.EmailAdapterListener {
     override fun onEmailArchived(email: Email) {
         EmailStore.delete(email.id)
     }
-
 }