Remove additional BottomAppBar menu item

hunterstich · hunterstich · commit e440e6db3b42 · 2019-10-14T08:51:38.000-07:00
Remove sun icon for theme selection in favor of settings icon.

Change-Id: Ibf1255ae35a7b15c9ce5d3989ddcc3c99e757690
diff --git a/app/src/main/java/com/materialstudies/reply/ui/MainActivity.kt b/app/src/main/java/com/materialstudies/reply/ui/MainActivity.kt
@@ -190,7 +190,7 @@ class MainActivity : AppCompatActivity(),
 
     override fun onMenuItemClick(item: MenuItem?): Boolean {
         when (item?.itemId) {
-            R.id.menu_theme -> {
+            R.id.menu_settings -> {
                 bottomNavDrawer.close()
                 showDarkThemeMenu()
             }
diff --git a/app/src/main/res/drawable/ic_wb_sunny_on_branded.xml b/app/src/main/res/drawable/ic_wb_sunny_on_branded.xml
diff --git a/app/src/main/res/menu/bottom_app_bar_settings_menu.xml b/app/src/main/res/menu/bottom_app_bar_settings_menu.xml
@@ -15,17 +15,10 @@
 <menu xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto">
 
-    <item
-        android:id="@+id/menu_theme"
-        android:icon="@drawable/ic_wb_sunny_on_branded"
-        app:showAsAction="ifRoom"
-        android:title="Theme"/>
-
     <item
         android:id="@+id/menu_settings"
         android:icon="@drawable/ic_settings_on_branded"
         app:showAsAction="ifRoom"
         android:title="Settings"/>
 
-
 </menu>

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ class MainActivity : AppCompatActivity(),`
`190`	`190`
`191`	`191`	`override fun onMenuItemClick(item: MenuItem?): Boolean {`
`192`	`192`	`when (item?.itemId) {`
`193`		`- R.id.menu_theme -> {`
	`193`	`+ R.id.menu_settings -> {`
`194`	`194`	`bottomNavDrawer.close()`
`195`	`195`	`showDarkThemeMenu()`
`196`	`196`	`}`