Fixing text field icons that are not clickable having ripple effect when text field is pressed.

Non clickable ImageViews inherit pressed state of parent views, so icons appeared as pressed even if they were not clickable/focusable.

PiperOrigin-RevId: 278381886
(cherry picked from commit 27f7f4c)

Author: leticiarossi

lib/java/com/google/android/material/internal/CheckableImageButton.java

@@ -42,6 +42,7 @@ public class CheckableImageButton extends AppCompatImageButton implements Checka
 
   private boolean checked;
   private boolean checkable = true;
+  private boolean pressable = true;
 
   public CheckableImageButton(Context context) {
     this(context, null);
@@ -92,6 +93,13 @@ public void toggle() {
     setChecked(!checked);
   }
 
+  @Override
+  public void setPressed(boolean pressed) {
+    if (pressable) {
+      super.setPressed(pressed);
+    }
+  }
+
   @Override
   public int[] onCreateDrawableState(int extraSpace) {
     if (checked) {
@@ -136,6 +144,16 @@ public boolean isCheckable() {
     return checkable;
   }
 
+  /** Sets image button to be pressable or not. */
+  public void setPressable(boolean pressable) {
+    this.pressable = pressable;
+  }
+
+  /** Returns whether the image button is pressable. */
+  public boolean isPressable() {
+    return pressable;
+  }
+
   static class SavedState extends AbsSavedState {
 
     boolean checked;

lib/java/com/google/android/material/textfield/TextInputLayout.java

@@ -574,6 +574,7 @@ public TextInputLayout(@NonNull Context context, @Nullable AttributeSet attrs, i
     ViewCompat.setImportantForAccessibility(
         errorIconView, ViewCompat.IMPORTANT_FOR_ACCESSIBILITY_NO);
     errorIconView.setClickable(false);
+    errorIconView.setPressable(false);
     errorIconView.setFocusable(false);
 
     final int helperTextTextAppearance =
@@ -2999,26 +3000,27 @@ private void applyIconTint(
   }
 
   private static void setIconOnClickListener(
-      @NonNull View iconView,
+      @NonNull CheckableImageButton iconView,
       @Nullable OnClickListener onClickListener,
       @Nullable OnLongClickListener onLongClickListener) {
     iconView.setOnClickListener(onClickListener);
     setIconClickable(iconView, onLongClickListener);
   }
 
   private static void setIconOnLongClickListener(
-      @NonNull View iconView, @Nullable OnLongClickListener onLongClickListener) {
+      @NonNull CheckableImageButton iconView, @Nullable OnLongClickListener onLongClickListener) {
     iconView.setOnLongClickListener(onLongClickListener);
     setIconClickable(iconView, onLongClickListener);
   }
 
   private static void setIconClickable(
-      @NonNull View iconView, @Nullable OnLongClickListener onLongClickListener) {
+      @NonNull CheckableImageButton iconView, @Nullable OnLongClickListener onLongClickListener) {
     boolean iconClickable = ViewCompat.hasOnClickListeners(iconView);
     boolean iconLongClickable = onLongClickListener != null;
     boolean iconFocusable = iconClickable || iconLongClickable;
     iconView.setFocusable(iconFocusable);
     iconView.setClickable(iconClickable);
+    iconView.setPressable(iconClickable);
     iconView.setLongClickable(iconLongClickable);
     ViewCompat.setImportantForAccessibility(
         iconView,