[RangeSlider] Fixed number of values changing in RangeSlider

#1460
#1393

PiperOrigin-RevId: 319980426
(cherry picked from commit 4eea03d)

Author: ymarian

lib/java/com/google/android/material/slider/BaseSlider.java

@@ -659,12 +659,22 @@ private void setValuesInternal(@NonNull ArrayList<Float> values) {
   private void createLabelPool() {
     // If there are too many labels, remove the extra ones from the end.
     if (labels.size() > values.size()) {
-      labels.subList(values.size(), labels.size()).clear();
+      List<TooltipDrawable> tooltipDrawables = labels.subList(values.size(), labels.size());
+      for (TooltipDrawable label : tooltipDrawables) {
+        if (ViewCompat.isAttachedToWindow(this)) {
+          detachLabelFromContentView(label);
+        }
+      }
+      tooltipDrawables.clear();
     }
 
     // If there's not enough labels, add more.
     while (labels.size() < values.size()) {
-      labels.add(labelMaker.createTooltipDrawable());
+      TooltipDrawable tooltipDrawable = labelMaker.createTooltipDrawable();
+      labels.add(tooltipDrawable);
+      if (ViewCompat.isAttachedToWindow(this)) {
+        attachLabelToContentView(tooltipDrawable);
+      }
     }
 
     // Add a stroke if there is more than one label for when they overlap.
@@ -1241,27 +1251,35 @@ protected void onAttachedToWindow() {
     super.onAttachedToWindow();
     // The label is attached on the Overlay relative to the content.
     for (TooltipDrawable label : labels) {
-      label.setRelativeToView(ViewUtils.getContentView(this));
+      attachLabelToContentView(label);
     }
   }
 
+  private void attachLabelToContentView(TooltipDrawable label) {
+    label.setRelativeToView(ViewUtils.getContentView(this));
+  }
+
   @Override
   protected void onDetachedFromWindow() {
     if (accessibilityEventSender != null) {
       removeCallbacks(accessibilityEventSender);
     }
 
     for (TooltipDrawable label : labels) {
-      ViewOverlayImpl contentViewOverlay = ViewUtils.getContentViewOverlay(this);
-      if (contentViewOverlay != null) {
-        contentViewOverlay.remove(label);
-        label.detachView(ViewUtils.getContentView(this));
-      }
+      detachLabelFromContentView(label);
     }
 
     super.onDetachedFromWindow();
   }
 
+  private void detachLabelFromContentView(TooltipDrawable label) {
+    ViewOverlayImpl contentViewOverlay = ViewUtils.getContentViewOverlay(this);
+    if (contentViewOverlay != null) {
+      contentViewOverlay.remove(label);
+      label.detachView(ViewUtils.getContentView(this));
+    }
+  }
+
   @Override
   protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
     super.onMeasure(