Skip to content

Commit dc17035

Browse files
cketchamdsn5ft
authored andcommitted
Fix height of Slider when floating label is false
PiperOrigin-RevId: 286201599
1 parent 4e0a016 commit dc17035

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

lib/java/com/google/android/material/slider/Slider.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -180,12 +180,10 @@ public class Slider extends View {
180180
@NonNull private TooltipDrawable label;
181181

182182
private int widgetHeight;
183-
private int widgetHeightLabel;
184183
private boolean floatingLabel;
185184
private int trackHeight;
186185
private int trackSidePadding;
187186
private int trackTop;
188-
private int trackTopLabel;
189187
private int thumbRadius;
190188
private int haloRadius;
191189
private int labelPadding;
@@ -322,11 +320,9 @@ public void onFocusChange(View v, boolean hasFocus) {
322320

323321
private void loadResources(@NonNull Resources resources) {
324322
widgetHeight = resources.getDimensionPixelSize(R.dimen.mtrl_slider_widget_height);
325-
widgetHeightLabel = resources.getDimensionPixelSize(R.dimen.mtrl_slider_widget_height_label);
326323

327324
trackSidePadding = resources.getDimensionPixelOffset(R.dimen.mtrl_slider_track_side_padding);
328325
trackTop = resources.getDimensionPixelOffset(R.dimen.mtrl_slider_track_top);
329-
trackTopLabel = resources.getDimensionPixelOffset(R.dimen.mtrl_slider_track_top_label);
330326

331327
labelPadding = resources.getDimensionPixelSize(R.dimen.mtrl_slider_label_padding);
332328
}
@@ -774,7 +770,7 @@ protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
774770
super.onMeasure(
775771
widthMeasureSpec,
776772
MeasureSpec.makeMeasureSpec(
777-
floatingLabel ? widgetHeight : widgetHeightLabel, MeasureSpec.EXACTLY));
773+
widgetHeight + (floatingLabel ? 0 : label.getIntrinsicHeight()), MeasureSpec.EXACTLY));
778774
}
779775

780776
@Override
@@ -833,7 +829,7 @@ private void updateHaloHotSpot() {
833829
}
834830

835831
private int calculateTop() {
836-
return floatingLabel ? trackTop : trackTopLabel;
832+
return trackTop + (floatingLabel ? 0 : label.getIntrinsicHeight());
837833
}
838834

839835
@Override

lib/java/com/google/android/material/slider/res/values/dimens.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,9 @@
1717
<resources>
1818

1919
<dimen name="mtrl_slider_widget_height">48dp</dimen>
20-
<dimen name="mtrl_slider_widget_height_label">68dp</dimen>
2120

2221
<dimen name="mtrl_slider_track_side_padding">16dp</dimen>
2322
<dimen name="mtrl_slider_track_top">24dp</dimen>
24-
<dimen name="mtrl_slider_track_top_label">44dp</dimen>
2523
<dimen name="mtrl_slider_track_height">4dp</dimen>
2624

2725
<dimen name="mtrl_slider_thumb_radius">10dp</dimen>

0 commit comments

Comments
 (0)