Skip to content

Commit 363fc05

Browse files
asynclizcopybara-github
authored andcommitted
chore: remove un-actionable todos from labs
PiperOrigin-RevId: 594112463
1 parent 9973b90 commit 363fc05

File tree

12 files changed

+13
-20
lines changed

12 files changed

+13
-20
lines changed

labs/badge/internal/badge.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {property} from 'lit/decorators.js';
99
import {classMap} from 'lit/directives/class-map.js';
1010

1111
/**
12-
* TODO(b/265340196): add docs
12+
* b/265340196 - add docs
1313
*/
1414
export class Badge extends LitElement {
1515
@property() value = '';

labs/navigationbar/internal/navigation-bar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {NavigationTabInteractionEvent} from './constants.js';
1818
import {NavigationBarState} from './state.js';
1919

2020
/**
21-
* TODO(b/265346501): add docs
21+
* b/265346501 - add docs
2222
*
2323
* @fires navigation-bar-activated {CustomEvent<tab: NavigationTab, activeIndex: number>}
2424
* Dispatched whenever the `activeIndex` changes. --bubbles --composed

labs/navigationdrawer/internal/_navigation-drawer-modal.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ $_reference: (
2323
'container-height': 100%,
2424
'container-shape': 0 16px 16px 0,
2525
'container-width': 360px,
26-
// TODO(b/216384393): Temporary existing token to use for shadow color
26+
// b/216384393 - Temporary existing token to use for shadow color
2727
'divider-color': #000,
2828
'modal-container-elevation': 1,
2929
'scrim-color': null,

labs/navigationdrawer/internal/_navigation-drawer.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ $_reference: (
2121
'container-height': 100%,
2222
'container-shape': 0 16px 16px 0,
2323
'container-width': 360px,
24-
// TODO(b/216384393): Temporary existing token to use for shadow color
24+
// b/216384393 - Temporary existing token to use for shadow color
2525
'divider-color': #000,
2626
'modal-container-elevation': 1,
2727
'standard-container-elevation': 0,

labs/navigationdrawer/internal/navigation-drawer-modal.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {ARIAMixinStrict} from '../../../internal/aria/aria.js';
1212
import {requestUpdateOnAriaChange} from '../../../internal/aria/delegate.js';
1313

1414
/**
15-
* TODO(b/265346501): add docs
15+
* b/265346501 - add docs
1616
*
1717
* @fires navigation-drawer-changed {CustomEvent<{opened: boolean}>}
1818
* Dispatched whenever the drawer opens or closes --bubbles --composed

labs/navigationdrawer/internal/navigation-drawer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {ARIAMixinStrict} from '../../../internal/aria/aria.js';
1414
import {requestUpdateOnAriaChange} from '../../../internal/aria/delegate.js';
1515

1616
/**
17-
* TODO(b/265346501): add docs
17+
* b/265346501 - add docs
1818
*
1919
* @fires navigation-drawer-changed {CustomEvent<{opened: boolean}>}
2020
* Dispatched whenever the drawer opens or closes --bubbles --composed

labs/navigationtab/internal/navigation-tab.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {requestUpdateOnAriaChange} from '../../../internal/aria/delegate.js';
1818
import {NavigationTabState} from './state.js';
1919

2020
/**
21-
* TODO(b/265346501): add docs
21+
* b/265346501 - add docs
2222
*
2323
* @fires navigation-tab-rendered {Event} Dispatched when the navigation tab's
2424
* DOM has rendered and custom element definition has loaded. --bubbles
@@ -117,7 +117,7 @@ export class NavigationTab extends LitElement implements NavigationTabState {
117117
}
118118

119119
handleClick() {
120-
// TODO(b/269772145): connect to ripple
120+
// b/269772145 - connect to ripple
121121
this.dispatchEvent(
122122
new CustomEvent('navigation-tab-interaction', {
123123
detail: {state: this},

labs/navigationtab/internal/state.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,4 @@ export interface NavigationTabState {
1616
* If true, when inactive label will be hidden.
1717
*/
1818
hideInactiveLabel: boolean;
19-
20-
/**
21-
* Inner button for the tab
22-
* TODO(b/229015424): Remove this when the jscompiler rename issue is
23-
* understood.
24-
*/
25-
buttonElement: HTMLElement | null;
2619
}

labs/segmentedbutton/internal/_outlined-segmented-button.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
@mixin styles() {
1717
$tokens: tokens.md-comp-outlined-segmented-button-values();
18-
// TODO(b/198759625): Remove spacing tokens once provided.
18+
// b/198759625 - Remove spacing tokens once provided.
1919
$tokens: map.merge(
2020
$tokens,
2121
(
@@ -33,7 +33,7 @@
3333
.md3-segmented-button__outline {
3434
border-radius: inherit;
3535
border-style: solid;
36-
// TODO(b/233762888): Move border-width and inset into theme after generating latest version of tokens.
36+
// Move border-width and inset into theme.
3737
border-width: 1px;
3838
inset: 0px -0.5px;
3939
pointer-events: none;

labs/segmentedbutton/internal/_shared.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
&.md3-segmented-button--selected.md3-segmented-button--with-label.md3-segmented-button--with-checkmark,
9999
&.md3-segmented-button--selected.md3-segmented-button--without-label.md3-segmented-button--with-checkmark {
100100
.md3-segmented-button__graphic {
101-
// TODO(b/198759625): Use padding token instead of hardcoded 8px value.
101+
// b/198759625 - Use padding token instead of hardcoded 8px value.
102102
width: calc(var(--_icon-size) + 8px);
103103
}
104104
}

0 commit comments

Comments
 (0)