Skip to content

Commit 563518b

Browse files
asynclizcopybara-github
authored andcommitted
fix(menu): use new elevation component
PiperOrigin-RevId: 499297369
1 parent c2fe5e1 commit 563518b

File tree

6 files changed

+25
-28
lines changed

6 files changed

+25
-28
lines changed

autocomplete/lib/_filled-autocomplete.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ $dark-theme: tokens.md-comp-filled-autocomplete-values(
186186
.md3-autocomplete__menu-surface {
187187
@include menu-surface.theme(
188188
(
189-
container-elevation-shadow: var(--_menu-container-elevation-shadow),
189+
container-elevation: var(--_menu-container-elevation),
190190
container-shape: var(--_menu-container-shape),
191191
)
192192
);

autocomplete/lib/_outlined-autocomplete.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ $dark-theme: tokens.md-comp-outlined-autocomplete-values(
174174
.md3-autocomplete__menu-surface {
175175
@include menu-surface.theme(
176176
(
177-
container-elevation-shadow: var(--_menu-container-elevation-shadow),
177+
container-elevation: var(--_menu-container-elevation),
178178
container-shape: var(--_menu-container-shape),
179179
)
180180
);

menu/lib/_menu.scss

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
@use 'sass:map';
1010

11-
@use '../../elevationold/lib/elevation-theme';
11+
@use '../../elevation/lib/elevation';
1212
@use '../../list/list';
1313
@use '../../list/list-item';
1414
@use '../../menusurface/menu-surface';
@@ -40,8 +40,11 @@ $_custom-property-prefix: 'menu';
4040
.md3-menu {
4141
@include menu-surface.theme(
4242
(
43-
container-elevation-shadow: var(--_container-elevation-shadow),
43+
container-elevation: var(--_container-elevation),
4444
container-shape: var(--_container-shape),
45+
container-shadow-color: var(--_container-shadow-color),
46+
container-surface-tint-layer-color:
47+
var(--_container-surface-tint-layer-color),
4548
)
4649
);
4750

@@ -101,11 +104,6 @@ $_custom-property-prefix: 'menu';
101104
}
102105

103106
@function _resolve-tokens($tokens) {
104-
$tokens: elevation-theme.resolve-theme(
105-
$tokens,
106-
map.get(resolvers.$material, 'elevation'),
107-
$shadow-color-token: 'container-shadow-color',
108-
$elevation-tokens: (container-elevation)
109-
);
107+
$tokens: elevation.resolve-tokens($tokens, 'container-elevation');
110108
@return $tokens;
111109
}

menusurface/lib/_md-comp-menu-surface.scss

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
//
55

66
@use 'sass:map';
7-
@use '../../elevationold/lib/elevation-theme';
8-
@use '../../sass/resolvers';
7+
@use '../../elevation/lib/elevation';
98
@use '../../tokens';
109

1110
$_default-deps: (
@@ -17,19 +16,12 @@ $_default-deps: (
1716
@function values($deps: $_default-deps, $exclude-hardcoded-values: false) {
1817
// Use menu tokens for default menu surface values.
1918
$menu-values: tokens.md-comp-menu-values($deps, $exclude-hardcoded-values);
20-
// Note that we don't use "real" elevation tokens here because menu surface
21-
// does not have defined tokens. Components that use menu surface are expected
22-
// to pass through their own resolved tokens.
23-
$menu-values: elevation-theme.resolve-theme(
24-
$menu-values,
25-
map.get(resolvers.$material, 'elevation'),
26-
$shadow-color-token: 'container-shadow-color',
27-
$elevation-tokens: (container-elevation)
28-
);
2919

3020
@return (
31-
container-elevation-shadow:
32-
map.get($menu-values, container-elevation-shadow),
33-
container-shape: map.get($menu-values, container-shape)
21+
container-elevation: map.get($menu-values, container-elevation),
22+
container-shadow-color: map.get($menu-values, container-shadow-color),
23+
container-shape: map.get($menu-values, container-shape),
24+
container-surface-tint-layer-color:
25+
map.get($menu-values, container-surface-tint-layer-color)
3426
);
3527
}

menusurface/lib/_menu-surface.scss

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
// Selector '.md3-*' should only be used in this project.
88

99
@use 'sass:map';
10-
@use '../../elevationold/lib/elevation-theme';
10+
@use '../../elevation/lib/elevation';
1111
@use '../../sass/theme';
1212
@use './md-comp-menu-surface';
1313

@@ -23,13 +23,15 @@ $_deceleration-curve-timing-function: cubic-bezier(0, 0, 0.2, 1) !default;
2323

2424
@mixin theme($tokens) {
2525
$tokens: theme.validate-theme(md-comp-menu-surface.values(), $tokens);
26+
$tokens: elevation.resolve-tokens($tokens, 'container-elevation');
2627
$tokens: theme.create-theme-vars($tokens, $_custom-property-prefix);
2728

2829
@include theme.emit-theme-vars($tokens);
2930
}
3031

3132
@mixin styles() {
3233
$tokens: md-comp-menu-surface.values();
34+
$tokens: elevation.resolve-tokens($tokens, 'container-elevation');
3335
$tokens: theme.create-theme-vars($tokens, $_custom-property-prefix);
3436

3537
:host {
@@ -57,13 +59,15 @@ $_deceleration-curve-timing-function: cubic-bezier(0, 0, 0.2, 1) !default;
5759
will-change: transform, opacity;
5860
z-index: $_z-index;
5961

60-
@include elevation-theme.theme-styles(
62+
@include elevation.theme(
6163
(
62-
shadow: var(--_container-elevation-shadow),
64+
level: var(--_container-elevation),
65+
shadow-color: var(--_container-shadow-color),
66+
surface-tint-color: var(--_container-surface-tint-layer-color),
6367
)
6468
);
6569

66-
.md3-elevation-overlay {
70+
md-elevation {
6771
z-index: 0;
6872
}
6973

menusurface/lib/menu-surface.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
// Style preference for leading underscores.
88
// tslint:disable:strip-private-property-underscore
99

10+
import '../../elevation/elevation.js';
11+
1012
import {html, LitElement, PropertyValues} from 'lit';
1113
import {property, query, state} from 'lit/decorators.js';
1214
import {ClassInfo, classMap} from 'lit/directives/class-map.js';
@@ -105,6 +107,7 @@ export abstract class MenuSurface extends LitElement {
105107
@keydown=${this.onKeydown}
106108
@opened=${this.registerBodyClick}
107109
@closed=${this.deregisterBodyClick}>
110+
<md-elevation shadow></md-elevation>
108111
<slot></slot>
109112
</div>`;
110113
}

0 commit comments

Comments
 (0)