Skip to content

Commit 6db76fa

Browse files
allan-chencopybara-github
authored andcommitted
refactor(select): Remove fullwidth property
PiperOrigin-RevId: 317731796
1 parent 8e21c78 commit 6db76fa

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
4545
- **BREAKING** `--mdc-tab-border-radius` has been removed to align with spec
4646
- **BREAKING** replaced `--mdc-dialog-shape-radius` with `--mdc-shape-medium`
4747
- **BREAKING** mwc-checkbox sizing changed to 48x48 by default for touch accessibility. Disable with `reducedTouchTarget` attribute or property.
48+
- **BREAKING** mwc-select's fullwidth property removed since it was behaving as initially expected. Use `width: 100%` on the root element to accomplish fullwidth.
4849

4950
## [v0.15.0] - 2020-05-05
5051

packages/select/src/mwc-select-base.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,6 @@ export abstract class SelectBase extends FormElement {
178178

179179
@property({type: Boolean}) required = false;
180180

181-
@property({type: Boolean}) fullwidth = false;
182-
183181
@property({type: Boolean}) naturalMenuWidth = false;
184182

185183
@property({type: Boolean}) protected isUiValid = true;
@@ -264,7 +262,6 @@ export abstract class SelectBase extends FormElement {
264262
'mdc-select--with-leading-icon': !!this.icon,
265263
'mdc-select--required': this.required,
266264
'mdc-select--invalid': !this.isUiValid,
267-
'mdc-select--fullwidth': this.fullwidth,
268265
};
269266

270267
const menuClasses = {

packages/select/src/mwc-select.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ limitations under the License.
3333
outline: none;
3434
}
3535

36+
.mdc-select {
37+
width: 100%;
38+
}
3639

3740
.hidden, [hidden] {
3841
display: none;

0 commit comments

Comments
 (0)