Skip to content

Commit 9c0336a

Browse files
asynclizcopybara-github
authored andcommitted
fix(chips): misaligned trailing action ripple
PiperOrigin-RevId: 538841541
1 parent 938bf38 commit 9c0336a

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

chips/lib/_trailing-icon.scss

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99

1010
@mixin styles() {
1111
.trailing.action {
12-
display: flex;
12+
align-items: center;
13+
justify-content: center;
1314
padding: 0 8px;
1415

1516
// Note: the trailing action's shape only follows the trailing end of the
@@ -29,8 +30,6 @@
2930
.trailing.action md-ripple {
3031
border-radius: 50%;
3132
height: calc(4 / 3 * var(--_icon-size)); // 24px default
32-
inset: 50% 0 0 50%;
33-
transform: translateX(-50%) translateY(-50%);
3433
width: calc(4 / 3 * var(--_icon-size)); // 24px default
3534
}
3635

chips/lib/filter-chip.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {property, query} from 'lit/decorators.js';
1212
import {ARIAMixinStrict} from '../../internal/aria/aria.js';
1313

1414
import {MultiActionChip} from './multi-action-chip.js';
15-
import {renderRemoveButton} from './trailing-actions.js';
15+
import {renderRemoveButton} from './trailing-icons.js';
1616

1717
/**
1818
* A filter chip component.

chips/lib/input-chip.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {property, query} from 'lit/decorators.js';
1010
import {ARIAMixinStrict} from '../../internal/aria/aria.js';
1111

1212
import {MultiActionChip} from './multi-action-chip.js';
13-
import {renderRemoveButton} from './trailing-actions.js';
13+
import {renderRemoveButton} from './trailing-icons.js';
1414

1515
/**
1616
* An input chip component.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {Chip} from './chip.js';
1515
export function renderRemoveButton({disabled}: {disabled: boolean}) {
1616
return html`
1717
<button class="trailing action"
18-
?disabled=${disabled ?? false}
18+
?disabled=${disabled}
1919
@click=${handleRemoveClick}
2020
>
2121
<md-focus-ring></md-focus-ring>

0 commit comments

Comments
 (0)