fix(dialog)!: fix exception when opening when compiled with advanced closure settings

material-web-copybara · copybara-github · commit c63a1d9caf82 · 2023-02-22T09:55:28.000-08:00
PiperOrigin-RevId: 511523151
diff --git a/dialog/lib/dialog.ts b/dialog/lib/dialog.ts
@@ -332,8 +332,7 @@ export class Dialog extends LitElement {
     // prevent body scrolling early only when opening to avoid layout
     // shift when closing.
     if (!this.modeless && this.open) {
-      (this.constructor as typeof Dialog)
-          .setDocumentScrollingDisabled(this.open);
+      Dialog.setDocumentScrollingDisabled(this.open);
     }
     if (this.open) {
       this.contentElement.scrollTop = 0;
@@ -410,8 +409,7 @@ export class Dialog extends LitElement {
       await closedPromise;
       // enable scrolling late to avoid layout shift when closing
       if (!this.modeless) {
-        (this.constructor as typeof Dialog)
-            .setDocumentScrollingDisabled(this.open);
+        Dialog.setDocumentScrollingDisabled(this.open);
       }
     }
     // Focus initial element.

Original file line number	Diff line number	Diff line change
`@@ -332,8 +332,7 @@ export class Dialog extends LitElement {`
`332`	`332`	`// prevent body scrolling early only when opening to avoid layout`
`333`	`333`	`// shift when closing.`
`334`	`334`	`if (!this.modeless && this.open) {`
`335`		`- (this.constructor as typeof Dialog)`
`336`		`- .setDocumentScrollingDisabled(this.open);`
	`335`	`+ Dialog.setDocumentScrollingDisabled(this.open);`
`337`	`336`	`}`
`338`	`337`	`if (this.open) {`
`339`	`338`	`this.contentElement.scrollTop = 0;`
`@@ -410,8 +409,7 @@ export class Dialog extends LitElement {`
`410`	`409`	`await closedPromise;`
`411`	`410`	`// enable scrolling late to avoid layout shift when closing`
`412`	`411`	`if (!this.modeless) {`
`413`		`- (this.constructor as typeof Dialog)`
`414`		`- .setDocumentScrollingDisabled(this.open);`
	`412`	`+ Dialog.setDocumentScrollingDisabled(this.open);`
`415`	`413`	`}`
`416`	`414`	`}`
`417`	`415`	`// Focus initial element.`