Skip to content

Commit c70198a

Browse files
dfreedmcopybara-github
authored andcommitted
fix(list,textfield): Fix TS 4.9 compliation of role property override.
PiperOrigin-RevId: 499312798
1 parent a6bbac5 commit c70198a

File tree

4 files changed

+9
-0
lines changed

4 files changed

+9
-0
lines changed

list/lib/divider/list-divider.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ import {ARIARole} from '../../../types/aria.js';
1313
/** @soyCompatible */
1414
export class ListDivider extends LitElement {
1515
@ariaProperty // tslint:disable-line:no-new-decorators
16+
// tslint:disable-next-line:decorator-placement
1617
@property({type: String, attribute: 'data-role', noAccessor: true})
18+
// @ts-ignore(b/264292293): Use `override` with TS 4.9+
1719
role: ARIARole = 'separator';
1820

1921
/** @soyTemplate */

list/lib/list.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ export class List extends LitElement {
3838
ariaActivedescendant!: string;
3939

4040
@ariaProperty // tslint:disable-line:no-new-decorators
41+
// tslint:disable-next-line:decorator-placement
4142
@property({type: String, attribute: 'data-role', noAccessor: true})
43+
// @ts-ignore(b/264292293): Use `override` with TS 4.9+
4244
role: ARIARole = 'list';
4345

4446
@property({type: String}) listId = '';

list/lib/listitem/list-item.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ import {ifDefined} from 'lit/directives/if-defined.js';
2020
/** @soyCompatible */
2121
export class ListItem extends ActionElement {
2222
@ariaProperty // tslint:disable-line:no-new-decorators
23+
// tslint:disable-next-line:decorator-placement
2324
@property({type: String, attribute: 'data-role', noAccessor: true})
25+
// @ts-ignore(b/264292293): Use `override` with TS 4.9+
2426
role: ARIARole = 'listitem';
2527

2628
@ariaProperty // tslint:disable-line:no-new-decorators

textfield/lib/text-field.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,12 @@ export abstract class TextField extends LitElement {
138138
@ariaProperty // tslint:disable-line:no-new-decorators
139139
ariaLabelledBy!: string;
140140

141+
// tslint:disable:decorator-placement
141142
@property({type: String, attribute: 'data-role', noAccessor: true})
142143
@ariaProperty // tslint:disable-line:no-new-decorators
144+
// @ts-ignore(b/264292293): Use `override` with TS 4.9+
143145
role: ARIARole|null = null;
146+
// tslint:enable:decorator-placement
144147

145148
// FormElement
146149
get form() {

0 commit comments

Comments
 (0)