Skip to content

Commit cc786d1

Browse files
AndrewJakubowiczcopybara-github
authored andcommitted
fix(segmentedbutton)!: remove with-* token prefixes
PiperOrigin-RevId: 546951852
1 parent 4ac1f76 commit cc786d1

File tree

3 files changed

+43
-20
lines changed

3 files changed

+43
-20
lines changed

labs/segmentedbutton/lib/_shared.scss

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@
7373
.md3-segmented-button__checkmark,
7474
.md3-segmented-button__icon,
7575
.md3-segmented-button__icon ::slotted([slot='icon']) {
76-
height: var(--_with-icon-icon-size);
77-
width: var(--_with-icon-icon-size);
78-
font-size: var(--_with-icon-icon-size);
76+
height: var(--_icon-size);
77+
width: var(--_icon-size);
78+
font-size: var(--_icon-size);
7979
}
8080

8181
// Under the following conditions, we need to account for extra space between
@@ -98,7 +98,7 @@
9898
&.md3-segmented-button--selected.md3-segmented-button--without-label.md3-segmented-button--with-checkmark {
9999
.md3-segmented-button__graphic {
100100
// TODO(b/198759625): Use padding token instead of hardcoded 8px value.
101-
width: calc(var(--_with-icon-icon-size) + 8px);
101+
width: calc(var(--_icon-size) + 8px);
102102
}
103103
}
104104

@@ -163,7 +163,7 @@
163163

164164
.md3-segmented-button--unselected {
165165
.md3-segmented-button__icon {
166-
color: var(--_unselected-with-icon-icon-color);
166+
color: var(--_unselected-icon-color);
167167
}
168168

169169
&:hover {
@@ -204,11 +204,11 @@
204204
background-color: var(--_selected-container-color);
205205

206206
.md3-segmented-button__icon {
207-
color: var(--_selected-with-icon-icon-color);
207+
color: var(--_selected-icon-color);
208208
}
209209

210210
.md3-segmented-button__checkmark-path {
211-
stroke: var(--_selected-with-icon-icon-color);
211+
stroke: var(--_selected-icon-color);
212212
}
213213

214214
&:hover {
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
/**
2+
* @license
3+
* Copyright 2023 Google LLC
4+
* SPDX-License-Identifier: Apache-2.0
5+
*/
6+
7+
// import 'jasmine'; (google3-only)
8+
9+
import {createTokenTests} from '../../testing/tokens.js';
10+
11+
import {MdOutlinedSegmentedButton} from './outlined-segmented-button.js';
12+
13+
describe('<md-outlined-segmented-button>', () => {
14+
describe('.styles', () => {
15+
createTokenTests(MdOutlinedSegmentedButton.styles);
16+
});
17+
});

tokens/_md-comp-outlined-segmented-button.scss

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,54 +16,54 @@
1616

1717
$supported-tokens: (
1818
// go/keep-sorted start
19-
'container-height',
2019
'disabled-icon-color',
21-
'disabled-icon-opacity',
2220
'disabled-label-text-color',
23-
'disabled-label-text-opacity',
2421
'disabled-outline-color',
25-
'disabled-outline-opacity',
26-
'focus-state-layer-opacity',
2722
'hover-state-layer-opacity',
23+
'icon-size',
2824
'label-text-type',
2925
'outline-color',
30-
'outline-width',
3126
'pressed-state-layer-opacity',
3227
'selected-container-color',
3328
'selected-focus-icon-color',
3429
'selected-focus-label-text-color',
35-
'selected-focus-state-layer-color',
3630
'selected-hover-icon-color',
3731
'selected-hover-label-text-color',
3832
'selected-hover-state-layer-color',
33+
'selected-icon-color',
3934
'selected-label-text-color',
4035
'selected-pressed-icon-color',
4136
'selected-pressed-label-text-color',
4237
'selected-pressed-state-layer-color',
43-
'selected-with-icon-icon-color',
44-
'shape',
4538
'unselected-focus-icon-color',
4639
'unselected-focus-label-text-color',
47-
'unselected-focus-state-layer-color',
4840
'unselected-hover-icon-color',
4941
'unselected-hover-label-text-color',
5042
'unselected-hover-state-layer-color',
43+
'unselected-icon-color',
5144
'unselected-label-text-color',
5245
'unselected-pressed-icon-color',
5346
'unselected-pressed-label-text-color',
5447
'unselected-pressed-state-layer-color',
55-
'unselected-with-icon-icon-color',
56-
'with-icon-icon-size',
5748
// go/keep-sorted end
5849
);
5950

6051
$unsupported-tokens: (
6152
// go/keep-sorted start
53+
'container-height',
54+
'disabled-icon-opacity',
55+
'disabled-label-text-opacity',
56+
'disabled-outline-opacity',
57+
'focus-state-layer-opacity',
6258
'label-text-font',
6359
'label-text-line-height',
6460
'label-text-size',
6561
'label-text-tracking',
6662
'label-text-weight',
63+
'outline-width',
64+
'selected-focus-state-layer-color',
65+
'shape',
66+
'unselected-focus-state-layer-color',
6767
// go/keep-sorted end
6868
);
6969

@@ -78,7 +78,13 @@ $_default: (
7878
$tokens: values.validate(
7979
md-comp-outlined-segmented-button.values($deps, $exclude-hardcoded-values),
8080
$supported-tokens: $supported-tokens,
81-
$unsupported-tokens: $unsupported-tokens
81+
$unsupported-tokens: $unsupported-tokens,
82+
$renamed-tokens: (
83+
// Remove "with-*" prefixes (b/273534858)
84+
'with-icon-icon-size': 'icon-size',
85+
'selected-with-icon-icon-color': 'selected-icon-color',
86+
'unselected-with-icon-icon-color': 'unselected-icon-color'
87+
)
8288
);
8389

8490
// TODO(b/271876162): remove when tokens compiler emits typescale tokens

0 commit comments

Comments
 (0)