Skip to content

Commit e18d913

Browse files
asynclizcopybara-github
authored andcommitted
chore(button): add unique aria labels to buttons with icons
PiperOrigin-RevId: 602512735
1 parent 6ecda49 commit e18d913

File tree

1 file changed

+20
-5
lines changed

1 file changed

+20
-5
lines changed

button/demo/stories.ts

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,27 +63,37 @@ const buttons: MaterialStoryInit<StoryKnobs> = {
6363
</md-text-button>
6464
</div>
6565
<div class="row">
66-
<md-filled-button ?disabled=${disabled}>
66+
<md-filled-button
67+
?disabled=${disabled}
68+
aria-label="${label || 'Filled'} button with icon">
6769
<md-icon slot="icon">upload</md-icon>
6870
${label || 'Filled'}
6971
</md-filled-button>
7072
71-
<md-outlined-button ?disabled=${disabled}>
73+
<md-outlined-button
74+
?disabled=${disabled}
75+
aria-label="${label || 'Outlined'} button with icon">
7276
<md-icon slot="icon">upload</md-icon>
7377
${label || 'Outlined'}
7478
</md-outlined-button>
7579
76-
<md-elevated-button ?disabled=${disabled}>
80+
<md-elevated-button
81+
?disabled=${disabled}
82+
aria-label="${label || 'Elevated'} button with icon">
7783
<md-icon slot="icon">upload</md-icon>
7884
${label || 'Elevated'}
7985
</md-elevated-button>
8086
81-
<md-filled-tonal-button ?disabled=${disabled}>
87+
<md-filled-tonal-button
88+
?disabled=${disabled}
89+
aria-label="${label || 'Tonal'} button with icon">
8290
<md-icon slot="icon">upload</md-icon>
8391
${label || 'Tonal'}
8492
</md-filled-tonal-button>
8593
86-
<md-text-button ?disabled=${disabled}>
94+
<md-text-button
95+
?disabled=${disabled}
96+
aria-label="${label || 'Text'} button with icon">
8797
<md-icon slot="icon">upload</md-icon>
8898
${label || 'Text'}
8999
</md-text-button>
@@ -137,6 +147,7 @@ const links: MaterialStoryInit<StoryKnobs> = {
137147
</div>
138148
<div class="row">
139149
<md-filled-button
150+
aria-label="${label || 'Filled'} link with trailing icon"
140151
href="https://google.com"
141152
target="_blank"
142153
trailing-icon>
@@ -145,6 +156,7 @@ const links: MaterialStoryInit<StoryKnobs> = {
145156
</md-filled-button>
146157
147158
<md-outlined-button
159+
aria-label="${label || 'Outlined'} link with trailing icon"
148160
href="https://google.com"
149161
target="_blank"
150162
trailing-icon>
@@ -153,6 +165,7 @@ const links: MaterialStoryInit<StoryKnobs> = {
153165
</md-outlined-button>
154166
155167
<md-elevated-button
168+
aria-label="${label || 'Elevated'} link with trailing icon"
156169
href="https://google.com"
157170
target="_blank"
158171
trailing-icon>
@@ -161,6 +174,7 @@ const links: MaterialStoryInit<StoryKnobs> = {
161174
</md-elevated-button>
162175
163176
<md-filled-tonal-button
177+
aria-label="${label || 'Tonal'} link with trailing icon"
164178
href="https://google.com"
165179
target="_blank"
166180
trailing-icon>
@@ -169,6 +183,7 @@ const links: MaterialStoryInit<StoryKnobs> = {
169183
</md-filled-tonal-button>
170184
171185
<md-text-button
186+
aria-label="${label || 'Text'} link with trailing icon"
172187
href="https://google.com"
173188
target="_blank"
174189
trailing-icon>

0 commit comments

Comments
 (0)