Skip to content

Commit ed6b866

Browse files
Elliott Marquezcopybara-github
authored andcommitted
feat(list,tab): add / forward missing exports
PiperOrigin-RevId: 331797412
1 parent a7fbc70 commit ed6b866

File tree

6 files changed

+22
-10
lines changed

6 files changed

+22
-10
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1818
- BaseElement.click() forwards focus to BaseElement.mdcRoot
1919
- `form-element`
2020
- FormElement.click() forwards focus to FormElement.formElement
21+
- `tab`
22+
- export for `TabInteractionEventDetail`
23+
- `list`
24+
- export for `ActionDetail`
25+
- export for `SelectedDetail`
2126

2227
### Changed
2328

packages/list/mwc-list-base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import MDCListFoundation, {ActionDetail, isIndexSet, SelectedDetail} from './mwc
2626
import {MWCListIndex} from './mwc-list-foundation';
2727
import {Layoutable, ListItemBase, RequestSelectedDetail} from './mwc-list-item-base';
2828

29-
export {createSetFromIndex, isEventMulti, isIndexSet, MWCListIndex} from './mwc-list-foundation';
29+
export {ActionDetail, createSetFromIndex, isEventMulti, isIndexSet, MWCListIndex, SelectedDetail} from './mwc-list-foundation';
3030

3131

3232
const isListItem = (element: Element): element is ListItemBase => {

packages/list/mwc-list.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {customElement} from 'lit-element';
2020
import {ListBase} from './mwc-list-base';
2121
import {style} from './mwc-list-css';
2222

23-
export {createSetFromIndex, isEventMulti, isIndexSet, MWCListIndex} from './mwc-list-foundation';
23+
export {ActionDetail, createSetFromIndex, isEventMulti, isIndexSet, MWCListIndex, SelectedDetail} from './mwc-list-foundation';
2424

2525
declare global {
2626
interface HTMLElementTagNameMap {

packages/menu/mwc-menu-base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import {html, property, query} from 'lit-element';
3030
import {MenuSurface} from './mwc-menu-surface';
3131
import {Corner, MenuCorner} from './mwc-menu-surface-base';
3232

33-
export {createSetFromIndex, isEventMulti, isIndexSet, MWCListIndex} from '@material/mwc-list/mwc-list-foundation';
33+
export {ActionDetail, createSetFromIndex, isEventMulti, isIndexSet, MWCListIndex, SelectedDetail} from '@material/mwc-list/mwc-list-foundation';
3434
export {Corner, MenuCorner} from './mwc-menu-surface-base';
3535

3636
export type DefaultFocusState = keyof typeof DefaultFocusStateEnum;

packages/tab/mwc-tab-base.ts

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ import MDCTabFoundation from '@material/tab/foundation';
2626
import {html, property, query} from 'lit-element';
2727
import {classMap} from 'lit-html/directives/class-map';
2828

29+
export interface TabInteractionEventDetail {
30+
tabId: string;
31+
}
32+
2933
// used for generating unique id for each tab
3034
let tabIdCounter = 0;
3135

@@ -160,13 +164,14 @@ export class TabBase extends BaseElement {
160164
.activate(previousIndicatorClientRect),
161165
deactivateIndicator: () =>
162166
(this._tabIndicator as TabIndicator).deactivate(),
163-
notifyInteracted: () => this.dispatchEvent(
164-
new CustomEvent(MDCTabFoundation.strings.INTERACTED_EVENT, {
165-
detail: {tabId: this.id},
166-
bubbles: true,
167-
composed: true,
168-
cancelable: true,
169-
})),
167+
notifyInteracted: () =>
168+
this.dispatchEvent(new CustomEvent<TabInteractionEventDetail>(
169+
MDCTabFoundation.strings.INTERACTED_EVENT, {
170+
detail: {tabId: this.id},
171+
bubbles: true,
172+
composed: true,
173+
cancelable: true,
174+
})),
170175
getOffsetLeft: () => this.offsetLeft,
171176
getOffsetWidth: () => this.mdcRoot.offsetWidth,
172177
getContentOffsetLeft: () => this._contentElement.offsetLeft,

packages/tab/mwc-tab.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ import {customElement} from 'lit-element';
1919
import {TabBase} from './mwc-tab-base';
2020
import {style} from './mwc-tab-css';
2121

22+
export {TabInteractionEventDetail} from './mwc-tab-base';
23+
2224
declare global {
2325
interface HTMLElementTagNameMap {
2426
'mwc-tab': Tab;

0 commit comments

Comments
 (0)