feat(list): add activeItem getter #5704
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdegenne
changed the title
asyncliz
requested changes
Sep 9, 2024
| * @return A record of the first activated item including the item and the | ||
| * index of the item or `null` if none are activated. | ||
| */ | ||
| get activeItem() { |
There was a problem hiding this comment.
Can you move this above next to the other get items() property and add @export to the jsdoc?
| @@ -90,4 +90,14 @@ export class List extends LitElement { | |||
| activatePreviousItem(): ListItem | null { | |||
| return this.listController.activatePreviousItem(); | |||
| } | |||
|
|
|||
| /** | |||
| * Retrieves the first activated item of the array of items. | |||
There was a problem hiding this comment.
nit: "array of items, or null." to be more explicit
| * index of the item or `null` if none are activated. | ||
| */ | ||
| get activeItem() { | ||
| return this.listController.activeItem; |
There was a problem hiding this comment.
I don't think we should expose the {item, index} object that the controller uses. Instead, I would suggest separate activeItem and activeItemIndex properties, like how tabs work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing this helper function to quickly retrieve the activated item in the list.